Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored Stripe views, collections and unit tests #27

Merged
merged 6 commits into from
Apr 1, 2022
Merged

Refactored Stripe views, collections and unit tests #27

merged 6 commits into from
Apr 1, 2022

Conversation

Zuiluj
Copy link
Contributor

@Zuiluj Zuiluj commented Jan 21, 2022

Changes

  • Refactored Stripe views to work better with PFunk View environment
  • Refactored Stripe collections
    • Added CheckoutSuccessView to StripePackage collection
    • Added BaseWebhookView to StripeCustomer collection
    • To be able to do CRUD operations
  • Added unit tests
    • Collection StripePackage and StripeCustomer CRUD operations
    • Webhook methods unit tests
    • CheckoutSuccessView unit tests

Files changed/added

  • pfunk/contrib/ecommerce/collections.py
  • pfunk/contrib/ecommerce/views.py

Notes

When unit testing, be sure to have TEMPLATE_ROOT_DIR=/tmp in your .env file. This is to ensure mocked file will be found.

@Zuiluj Zuiluj requested a review from bjinwright January 21, 2022 08:20
@Zuiluj Zuiluj self-assigned this Jan 21, 2022
@Zuiluj Zuiluj mentioned this pull request Jan 21, 2022
Closed
3 tasks
@bjinwright bjinwright merged commit 17dcc3a into feature/api Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjinwright bjinwright bjinwright left review comments

Assignees

@Zuiluj Zuiluj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zuiluj @bjinwright