DCM code fixes #29
DCM code fixes #29
Conversation
DCM/Src/controls.c
Outdated
| @@ -73,7 +73,17 @@ static TickType_t previousTickCount; | |||
|
|
|||
| // ------------------------------------------------------------------------------------------------ | |||
| // Function implementations | |||
|
|
|||
| void setFastTorqueWithParallelRegen(uint8_t brakePressurePsi_u8, uint8_t throttlePos_u8); | |||
There was a problem hiding this comment.
why are these prototypes set in the .c?
There was a problem hiding this comment.
we define the function after the point where we call it.
There was a problem hiding this comment.
forward declaration
There was a problem hiding this comment.
could this line be moved to controls.h just to be consistent with other functions?
| @@ -89,7 +89,7 @@ struct cmr_can { | |||
| cmr_canRXCallback_t rxCallback; | |||
| }; | |||
|
|
|||
| void cmr_canInit( | |||
| void cmr_FDcanInit( | |||
There was a problem hiding this comment.
oml how did this work lmfao
| @@ -16,6 +16,7 @@ | |||
| #ifdef HAL_FDCAN_MODULE_ENABLED | |||
|
|
|||
| uint32_t _platform_FDcanGPIOAF(FDCAN_GlobalTypeDef *instance, GPIO_TypeDef *port); | |||
| void _platform_rccFDCanClockEnable(); | |||
There was a problem hiding this comment.
does this need to be in here or does it exist only in rcc?
There was a problem hiding this comment.
_platform_rccFDCanClockEnable() is only called in rcc.c but defined in h725.c
There was a problem hiding this comment.
It should stay in h275 imo since its platform specific
| @@ -55,10 +55,11 @@ void setEnduranceTestTorque( | |||
| // Public functions | |||
|
|
|||
| void initControls(); | |||
| void integrateCurrent(); | |||
There was a problem hiding this comment.
integrateCurrent() is called in motors.c, how did this even compile lol
DCM borked on GCC 14