Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added conditional extension delimiter #70

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

calebanderson
Copy link

Characters wrapped in %d{} only appear when the extension is present. This would be able to be merged in now without changing any of the old behavior and allow an amount of flexibility that is quite useful.
I completely understand if this isn't in the spirit of the gem and doesn't get merged, but I found it useful and thought you might like the idea.

@elskwid
Copy link
Collaborator

elskwid commented Aug 23, 2015

@calebanderson I dig the idea. Did you give any thought to using a token related to %x? Like maybe %X? Wondering if we could make it easier for a person looking at the string to understand those things are linked.

@calebanderson
Copy link
Author

@elskwid I did originally, but that ended up looking like %a %n%X{ x}%x and that had too many x's for my taste. It's a simple change though.
EDIT: I chose %d for extension delimiter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants