[WIP] Add fees and coin selection #159
Draft
+538
−252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callebtc
force-pushed
the
fees-and-coinselection
branch
from
9c4e4a3
to
cbb98a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces support for fees for spending ecash with the mint. Fees are published in the
/v1/keysetsresponse (see NUT-02). Also introduces a new input coinselection algorithm to minimize fees when spending coins and an output selection, to maintain a diverse set of amounts in the user's wallet, increasing the chance for being able to make offline transactions in the future.PR Tasks
npm run test--> no failing unit testsnpm run format