WIP: Nut-17 #394
Draft
WIP: Nut-17 #394
+1,197
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very early stage non functional prototype to add support for any kind of subscriptions, aiming for NUT-17 support
There are two functions, an async and a fire and forget version
crodas
force-pushed
the
nut-17-ws-subscription
branch
from
1f264e4
to
3cbc5af
Compare
I do not like `unwrap()`
crodas
force-pushed
the
nut-17-ws-subscription
branch
from
a870922
to
083a802
Compare
This implementation does not rely on any new crate, instead it implements the types for the WebSocket. This is WIP, so this commit will be rebased and keep changing
crodas
force-pushed
the
nut-17-ws-subscription
branch
2 times, most recently
from
c1cdd09
to
be9ce64
Compare
Also dropped `tokio::select` since it is not stable in 1.63
crodas
force-pushed
the
nut-17-ws-subscription
branch
from
be9ce64
to
fd4191a
Compare
crodas
force-pushed
the
nut-17-ws-subscription
branch
from
88cdf9e
to
672a4fd
Compare
|
Hey, haven't done a very through review but it looks like a good approach so far, thank you for you work. If there is a specific part you would like me to look at let me know. |
Instead of letting Axum create it and use it for their WebSocket, make it part of Mint so that event subscriptions and publishing can happen in all layers. Also added helper functions to emit events Some typos in comments were fixed in this commit as well
|
@thesimplekid I have no idea where the events are being generated, and any other feedback is more than welcome. |
I think the `subscription_manager` was a bit unintuitive; I think `pubsub_manager` is a much more descriptive name.
crodas
force-pushed
the
nut-17-ws-subscription
branch
from
7163235
to
74b9ee4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very early stage nonfunctional prototype to add support for any subscriptions, aiming for NUT-17 support, #203 .
TODO: