Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add during_initial_install check in update_object_by_hash function #570

Open
wants to merge 4 commits into
base: MOODLE_310_STABLE
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Jul 10, 2023

No description provided.

@ghost ghost self-assigned this Jul 10, 2023
@ghost ghost requested review from danmarsden and jwalits July 10, 2023 04:21
@ghost ghost changed the title add table_exists check in update_object_by_hash function add during_initial_install check in update_object_by_hash function Jul 10, 2023
@@ -139,6 +139,10 @@ public static function update_object_by_hash($contenthash, $newlocation, $filesi
$newobject = new stdClass();
$newobject->contenthash = $contenthash;

if (during_initial_install()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not do this first above line 139?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant