Skip to content

Commit

Permalink
Add multiline test
Browse files Browse the repository at this point in the history
  • Loading branch information
jeremystucki committed Aug 14, 2019
1 parent dbe2bb4 commit 214d499
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 1 deletion.
8 changes: 8 additions & 0 deletions tests/ui/unnecessary_fold.fixed
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,12 @@ fn unnecessary_fold_should_ignore() {
let _ = [(0..2), (0..3)].iter().fold(1, |a, b| a * b.len());
}

/// Should lint only the line containing the fold
fn unnecessary_fold_over_multiple_lines() {
let _ = (0..3)
.map(|x| x + 1)
.filter(|x| x % 2 == 0)
.any(|x| x > 2);
}

fn main() {}
8 changes: 8 additions & 0 deletions tests/ui/unnecessary_fold.rs
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,12 @@ fn unnecessary_fold_should_ignore() {
let _ = [(0..2), (0..3)].iter().fold(1, |a, b| a * b.len());
}

/// Should lint only the line containing the fold
fn unnecessary_fold_over_multiple_lines() {
let _ = (0..3)
.map(|x| x + 1)
.filter(|x| x % 2 == 0)
.fold(false, |acc, x| acc || x > 2);
}

fn main() {}
8 changes: 7 additions & 1 deletion tests/ui/unnecessary_fold.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,11 @@ error: this `.fold` can be written more succinctly using another method
LL | let _: bool = (0..3).map(|x| 2 * x).fold(false, |acc, x| acc || x > 2);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.any(|x| x > 2)`

error: aborting due to 5 previous errors
error: this `.fold` can be written more succinctly using another method
--> $DIR/unnecessary_fold.rs:49:10
|
LL | .fold(false, |acc, x| acc || x > 2);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `any(|x| x > 2)`

error: aborting due to 6 previous errors

0 comments on commit 214d499

Please sign in to comment.