Skip to content

Commit

Permalink
🔗📏 Lint Rules
Browse files Browse the repository at this point in the history
  • Loading branch information
amanxnanda committed Nov 9, 2021
1 parent 42bf27d commit 624db51
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 15 deletions.
1 change: 1 addition & 0 deletions analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ analyzer:
- lib/core/models/app_models.g.dart
- test/helpers/test_helpers.mocks.dart
- test/helpers/test_helpers.dart
- lib/ui/invite/invite_view.form.dart
errors:
todo: warning

Expand Down
3 changes: 1 addition & 2 deletions lib/app/app.logger.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions lib/core/services/feed_service.dart
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import 'package:feed/app/app.locator.dart';
import 'package:feed/app/app.logger.dart';
import 'package:feed/core/models/app_models.dart';
import 'package:feed/core/services/topic_service.dart';
import 'package:feed/core/services/user_service.dart';
import 'package:feed/core/services/video_service.dart';
import 'package:feed/remote/api/api_service.dart';
Expand All @@ -10,7 +9,6 @@ class FeedService {
final _log = getLogger("Feed Service");
final _apiService = locator<APIService>();
final _userService = locator<UserService>();
final _topicService = locator<TopicService>();
final _videoService = locator<VideoService>();

/// Fetches videos from graphql api
Expand Down
2 changes: 0 additions & 2 deletions lib/firebase/fcm_service.dart
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ class FcmService {
FirebaseMessaging.onMessage.listen((RemoteMessage message) async {
_log.v(message);

print('From setupFCM: ${message.data}');

final title = message.data["title"];
final body = message.data["body"];
final videoId = message.data["videoId"];
Expand Down
8 changes: 4 additions & 4 deletions lib/ui/invite/invite_view.form.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 2 additions & 5 deletions lib/ui/single_video/single_video_viewmodel.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ import 'package:stacked_services/stacked_services.dart';

class SingleFeedViewModel extends BaseFeedModel {
final _feedService = locator<FeedService>();
final VideoManagerService _videoManagerService =
locator<VideoManagerService>();
final VideoManagerService _videoManagerService = locator<VideoManagerService>();
final NavigationService _navigationService = locator<NavigationService>();
late String videoId;

Expand All @@ -33,9 +32,7 @@ class SingleFeedViewModel extends BaseFeedModel {
}

_videos.add(video);
} catch (e) {
print('From SingleVideoViewmodel $e');
}
} catch (_) {}

setBusy(false);
}
Expand Down

0 comments on commit 624db51

Please sign in to comment.