Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve install process #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

code-IM-perfect
Copy link
Contributor

@code-IM-perfect code-IM-perfect commented Oct 25, 2024

Kvantum manager does not allow batch install and all it does in the backend is copy the folder to ~/.config/kvantum, so I changed the install process to install all the themes at once. (it can be a pain in the ass to install them individually)

The desired flavor can then be chosen from Kvantum Manager itself as if it was installed from it.

Also added the logical in-betweens like cloning etc

Signed-off-by: Harshit Tomar <[email protected]>
@code-IM-perfect
Copy link
Contributor Author

@sgoudham pls review

@sgoudham sgoudham self-requested a review November 1, 2024 09:34
@code-IM-perfect
Copy link
Contributor Author

Is there an issue with this approach?

@sgoudham
Copy link
Contributor

Is there an issue with this approach?

Sorry, this is fairly low priority for me so I haven't gotten around to it until now.

When it comes to ports that simply require you to move file(s) from the repository to a location in your file system. I've actually started to favour and recommend simply saying "Download the file from x...." instead of providing the whole git clone and something like curl or wget commands.

Ultimately, it comes down to the fact that we don't want people to blindly copy/paste commands from the README without understanding what they do. Also this can open up to PRs where some people have issues with curl because of their system and then open a PR to use wget and then wget breaks for another set of users...

Granted, in this case, it's fairly mild since it's git clone and cp but I'd rather leave it as general as possible and the user can decide how to copy files to their system. I'd be very surprised if someone wants to rice/theme their Linux operating system and did not know of the cp command already.

I hope you can understand my reasoning on why I'm not so keen on accepting this PR atm. I'm open to have a discussion if you really do feel these commands need to exist on the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants