-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Extended BDL input iterator to support different SiDB input representations #521
✨ Extended BDL input iterator to support different SiDB input representations #521
Conversation
…ms of perturber placement.
Signed-off-by: GitHub Actions <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #521 +/- ##
==========================================
+ Coverage 98.14% 98.16% +0.01%
==========================================
Files 224 224
Lines 31298 31436 +138
Branches 1564 1564
==========================================
+ Hits 30718 30858 +140
+ Misses 580 578 -2
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
experiments/sidb_simulation/temperature/critical_temperature_simulation_siqad.cpp
Show resolved
Hide resolved
experiments/sidb_simulation/temperature/critical_temperature_simulation_siqad.cpp
Show resolved
Hide resolved
experiments/sidb_simulation/temperature/critical_temperature_simulation_siqad.cpp
Show resolved
Hide resolved
experiments/sidb_simulation/temperature/critical_temperature_simulation_siqad.cpp
Show resolved
Hide resolved
experiments/sidb_simulation/temperature/critical_temperature_simulation_siqad.cpp
Show resolved
Hide resolved
Signed-off-by: GitHub Actions <[email protected]>
…mperature_experiments' into update_bdl_input_iterator_and_temperature_experiments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
experiments/sidb_simulation/temperature/critical_temperature_simulation_siqad.cpp
Show resolved
Hide resolved
experiments/sidb_simulation/temperature/critical_temperature_simulation_siqad.cpp
Show resolved
Hide resolved
experiments/sidb_simulation/temperature/critical_temperature_simulation_siqad.cpp
Show resolved
Hide resolved
experiments/sidb_simulation/temperature/critical_temperature_simulation_siqad.cpp
Show resolved
Hide resolved
Signed-off-by: GitHub Actions <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
experiments/sidb_simulation/temperature/critical_temperature_simulation_siqad.cpp
Show resolved
Hide resolved
experiments/sidb_simulation/temperature/critical_temperature_simulation_siqad.cpp
Show resolved
Hide resolved
experiments/sidb_simulation/temperature/critical_temperature_simulation_siqad.cpp
Show resolved
Hide resolved
experiments/sidb_simulation/temperature/critical_temperature_simulation_siqad.cpp
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/random_sidb_layout_generator.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: GitHub Actions <[email protected]>
@Drewniok can you still add a CHANGELOG entry, please? |
…mperature_experiments' into update_bdl_input_iterator_and_temperature_experiments
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
Description
This PR extends the BDL input iterator to accommodate the varying ways input information can be implemented in SiDB technology. In some cases, such as with Bestagon gates, the binary value
0
may be represented by a perturber placed farther away compared to the1
state. In contrast, SiQAD gates typically represent0
by the absence of a perturber and1
by the presence of a perturber.In addition, this PR includes the missing experiment scripts needed for temperature simulation.
Checklist: