Refactor JSON::writeNext

cdosborn · Jan 28, 2023 · 3dde66d · 3dde66d
1 parent dfa7d41
commit 3dde66d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 12 deletions.
diff --git a/include/qpdf/JSON.hh b/include/qpdf/JSON.hh
@@ -338,7 +338,6 @@ class JSON
     static std::string encode_string(std::string const& utf8);
     static void
     writeClose(Pipeline* p, bool first, size_t depth, char const* delimeter);
-    static void writeIndent(Pipeline* p, size_t depth);
 
     struct JSON_value
     {

diff --git a/libqpdf/JSON.cc b/libqpdf/JSON.cc
@@ -41,24 +41,19 @@ JSON::writeClose(Pipeline* p, bool first, size_t depth, char const* delimiter)
     }
 }
 
-void
-JSON::writeIndent(Pipeline* p, size_t depth)
-{
-    for (size_t i = 0; i < depth; ++i) {
-        *p << "  ";
-    }
-}
-
 void
 JSON::writeNext(Pipeline* p, bool& first, size_t depth)
 {
     if (first) {
         first = false;
+        std::string s{"\n"};
+        s.append(2 * depth, ' ');
+        *p << s;
     } else {
-        *p << ",";
+        std::string s{",\n"};
+        s.append(2 * depth, ' ');
+        *p << s;
     }
-    *p << "\n";
-    writeIndent(p, depth);
 }
 
 void