Merge branch 'legacy/pm3' into stable

.php-cs-fixer.php

@@ -74,6 +74,7 @@
 		'return_type_declaration' => [
 			'space_before' => 'one'
 		],
+		'single_blank_line_at_eof' => true,
 		'single_import_per_statement' => true,
 		'strict_param' => true,
 		'unary_operator_spaces' => true,

build/generate-registry-annotations.php

@@ -116,4 +116,3 @@ function generateMethodAnnotations(string $namespaceName, array $members) : stri
 		echo "No changes made to file $file\n";
 	}
 }
-

src/block/inventory/CraftingTableInventory.php

@@ -34,4 +34,4 @@ public function __construct(Position $holder){
 		$this->holder = $holder;
 		parent::__construct(CraftingGrid::SIZE_BIG);
 	}
-}
+}

src/crafting/FurnaceRecipeManager.php

@@ -65,4 +65,4 @@ public function register(FurnaceRecipe $recipe) : void{
 	public function match(Item $input) : ?FurnaceRecipe{
 		return $this->furnaceRecipes[$input->getId() . ":" . $input->getMeta()] ?? $this->furnaceRecipes[$input->getId() . ":?"] ?? null;
 	}
-}
+}

src/crash/CrashDumpData.php

@@ -81,4 +81,4 @@ public function jsonSerialize() : array{
 		$result["server.properties"] = $this->serverDotProperties;
 		return $result;
 	}
-}
+}

src/crash/CrashDumpDataGeneral.php

@@ -43,4 +43,4 @@ public function __construct(
 		public string $os,
 		public array $composer_libraries,
 	){}
-}
+}

src/crash/CrashDumpDataPluginEntry.php

@@ -42,4 +42,4 @@ public function __construct(
 		public string $load,
 		public string $website,
 	){}
-}
+}

src/crash/CrashDumpRenderer.php

@@ -100,4 +100,4 @@ public function renderHumanReadable() : void{
 	public function addLine(string $line = "") : void{
 		fwrite($this->fp, $line . PHP_EOL);
 	}
-}
+}

src/data/SavedDataLoadingException.php

@@ -25,4 +25,4 @@
 
 final class SavedDataLoadingException extends \RuntimeException{
 
-}
+}

src/data/bedrock/LegacyBiomeIdToStringIdMap.php

@@ -32,4 +32,4 @@ final class LegacyBiomeIdToStringIdMap extends LegacyToStringBidirectionalIdMap{
 	public function __construct(){
 		parent::__construct(Path::join(\pocketmine\BEDROCK_DATA_PATH, 'biome_id_map.json'));
 	}
-}
+}

src/entity/InvalidSkinException.php

@@ -25,4 +25,4 @@
 
 final class InvalidSkinException extends \InvalidArgumentException{
 
-}
+}

src/entity/effect/StringToEffectParser.php

@@ -70,4 +70,4 @@ private static function make() : self{
 	public function parse(string $input) : ?Effect{
 		return parent::parse($input);
 	}
-}
+}

src/event/block/BlockItemPickupEvent.php

@@ -57,4 +57,4 @@ public function getInventory() : ?Inventory{
 	public function setInventory(?Inventory $inventory) : void{
 		$this->inventory = $inventory;
 	}
-}
+}

src/event/block/StructureGrowEvent.php

@@ -37,4 +37,4 @@ public function getTransaction() : BlockTransaction{
 	public function getPlayer() : ?Player{
 		return $this->player;
 	}
-}
+}

src/event/player/PlayerDisplayNameChangeEvent.php

@@ -45,4 +45,4 @@ public function getOldName() : string{
 	public function getNewName() : string{
 		return $this->newName;
 	}
-}
+}

src/inventory/PlayerCraftingInventory.php

@@ -33,4 +33,4 @@ public function __construct(private Player $holder){
 	}
 
 	public function getHolder() : Player{ return $this->holder; }
-}
+}

src/inventory/TemporaryInventory.php

@@ -25,4 +25,4 @@
 
 interface TemporaryInventory extends Inventory{
 
-}
+}

src/item/enchantment/StringToEnchantmentParser.php

@@ -63,4 +63,4 @@ private static function make() : self{
 	public function parse(string $input) : ?Enchantment{
 		return parent::parse($input);
 	}
-}
+}

src/network/NetworkInterfaceStartException.php

@@ -29,4 +29,4 @@
  */
 final class NetworkInterfaceStartException extends \RuntimeException{
 
-}
+}

src/network/mcpe/compression/Compressor.php

@@ -33,4 +33,4 @@ public function willCompress(string $data) : bool;
 	public function decompress(string $payload) : string;
 
 	public function compress(string $payload) : string;
-}
+}

src/network/mcpe/compression/DecompressionException.php

@@ -25,4 +25,4 @@
 
 final class DecompressionException extends \RuntimeException{
 
-}
+}

src/network/mcpe/raklib/RakLibThreadCrashInfo.php

@@ -59,4 +59,4 @@ public function getLine() : int{ return $this->line; }
 	public function makePrettyMessage() : string{
 		return sprintf("%s: \"%s\" in %s on line %d", $this->class ?? "Fatal error", $this->message, Filesystem::cleanPath($this->file), $this->line);
 	}
-}
+}

src/plugin/PluginLoadTriageEntry.php

@@ -39,4 +39,4 @@ public function getFile() : string{ return $this->file; }
 	public function getLoader() : PluginLoader{ return $this->loader; }
 
 	public function getDescription() : PluginDescription{ return $this->description; }
-}
+}

src/plugin/PluginLoadabilityChecker.php

@@ -110,4 +110,4 @@ public function check(PluginDescription $description) : Translatable|null{
 
 		return null;
 	}
-}
+}

src/promise/Promise.php

@@ -52,4 +52,4 @@ public function onCompletion(\Closure $onSuccess, \Closure $onFailure) : void{
 	public function isResolved() : bool{
 		return $this->shared->resolved;
 	}
-}
+}

src/promise/PromiseResolver.php

@@ -72,4 +72,4 @@ public function reject() : void{
 	public function getPromise() : Promise{
 		return $this->promise;
 	}
-}
+}

src/utils/SingletonTrait.php

@@ -45,4 +45,4 @@ public static function setInstance(self $instance) : void{
 	public static function reset() : void{
 		self::$instance = null;
 	}
-}
+}

src/utils/StringToTParser.php

@@ -79,4 +79,4 @@ protected function reprocess(string $input) : string{
 	public function getKnownAliases() : array{
 		return array_keys($this->callbackMap);
 	}
-}
+}

src/world/ChunkLockId.php

@@ -35,4 +35,4 @@
 final class ChunkLockId{
 	use NotCloneable;
 	use NotSerializable;
-}
+}

src/world/generator/FlatGeneratorOptions.php

@@ -124,4 +124,4 @@ public static function parsePreset(string $presetString) : self{
 		return new self($structure, $biomeId, $options);
 	}
 
-}
+}

src/world/generator/GeneratorManagerEntry.php

@@ -45,4 +45,4 @@ public function validateGeneratorOptions(string $generatorOptions) : void{
 			throw $exception;
 		}
 	}
-}
+}

tests/phpstan/rules/UnsafeForeachArrayOfStringRule.php

@@ -87,4 +87,4 @@ public function processNode(Node $node, Scope $scope) : array{
 		return [];
 	}
 
-}
+}

tests/phpunit/utils/fixtures/TestAbstractClass.php

@@ -6,4 +6,4 @@
 
 abstract class TestAbstractClass{
 
-}
+}

tests/phpunit/utils/fixtures/TestInstantiableClass.php

@@ -6,4 +6,4 @@
 
 class TestInstantiableClass extends TestAbstractClass implements TestInterface{
 
-}
+}

tests/phpunit/utils/fixtures/TestInterface.php

@@ -6,4 +6,4 @@
 
 interface TestInterface{
 
-}
+}

tests/phpunit/utils/fixtures/TestSubclassOfInstantiableClass.php

@@ -6,4 +6,4 @@
 
 class TestSubclassOfInstantiableClass extends TestInstantiableClass{
 
-}
+}

tests/phpunit/utils/fixtures/TestTrait.php

@@ -6,4 +6,4 @@
 
 trait TestTrait{
 
-}
+}