Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added cloud-event support #31

Closed
wants to merge 4 commits into from

Conversation

rjtch
Copy link
Contributor

@rjtch rjtch commented Mar 3, 2024

No description provided.

@rjtch
Copy link
Contributor Author

rjtch commented Mar 3, 2024

@davidB i added the cloudevent here! let me know what you think

Copy link
Contributor

@davidB davidB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Why did you rename cdevent into cd_event?
  2. source & sink on a "same" protocol could be chained. I mean that HTTP request send by HttpSink could be received by HttpSource (idem for futures other protocol).

cdviz-collector/Cargo.toml Outdated Show resolved Hide resolved
cdviz-collector/src/main.rs Outdated Show resolved Hide resolved
cdviz-collector/src/middleware/event_filter.rs Outdated Show resolved Hide resolved
cdviz-collector/src/sinks/http.rs Outdated Show resolved Hide resolved
cdviz-collector/src/sinks/http.rs Outdated Show resolved Hide resolved
cdviz-collector/src/sources/http.rs Outdated Show resolved Hide resolved
cdviz-collector/src/sources/http.rs Outdated Show resolved Hide resolved
demos/demos.http Show resolved Hide resolved
demos/sample_cloud_event.json Outdated Show resolved Hide resolved
demos/service_deployed.json Outdated Show resolved Hide resolved
rjtch added 2 commits March 10, 2024 20:32
Signed-off-by: Hergy Fongue <[email protected]>
@rjtch rjtch force-pushed the integration-with-cloudevents-#21 branch from 257889c to 448fdc5 Compare March 10, 2024 19:33
Copy link
Contributor

@davidB davidB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take care of the formatting rules, tell me if a configuration or tool/ci should be setup.
Try to make focused changes.

cdviz-collector/src/sinks/http.rs Outdated Show resolved Hide resolved
cdviz-collector/src/main.rs Show resolved Hide resolved
cdviz-collector/src/sinks/http.rs Outdated Show resolved Hide resolved
cdviz-collector/src/sinks/http.rs Outdated Show resolved Hide resolved
cdviz-collector/src/sources/http.rs Show resolved Hide resolved
@davidB
Copy link
Contributor

davidB commented Mar 26, 2024

Look into the "Files change" view of the PR, you'll notice useless change or not clean revert.
Also I push a big reorganisation of the project layout that could impact you (on the rebase,...), eg:

  • remove of justfile (replaced by taskfile)
  • remove of the cargo workspace, no cdviz-collector is a standalone cargo project (I suggest that you import cdviz-collector as a root project into your IDE, editor)

Thanks for your contribution

@rjtch
Copy link
Contributor Author

rjtch commented Apr 2, 2024

Look into the "Files change" view of the PR, you'll notice useless change or not clean revert. Also I push a big reorganisation of the project layout that could impact you (on the rebase,...), eg:

* remove of justfile (replaced by taskfile)

* remove of the cargo workspace, no cdviz-collector is a standalone cargo project (I suggest that you import cdviz-collector as a root project into your IDE, editor)

Thanks for your contribution

Thank you for the reply. Sorry, i use a custom linter in my IDE i will remove it, close this pr and make a new simple a short one.

@rjtch rjtch closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants