-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added cloud-event support #31
Conversation
@davidB i added the cloudevent here! let me know what you think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Why did you rename
cdevent
intocd_event
? - source & sink on a "same" protocol could be chained. I mean that HTTP request send by HttpSink could be received by HttpSource (idem for futures other protocol).
Signed-off-by: rjtch <[email protected]>
Signed-off-by: Hergy Fongue <[email protected]>
257889c
to
448fdc5
Compare
Signed-off-by: Hergy Fongue <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take care of the formatting rules, tell me if a configuration or tool/ci should be setup.
Try to make focused changes.
Signed-off-by: Hergy Fongue <[email protected]>
Look into the "Files change" view of the PR, you'll notice useless change or not clean revert.
Thanks for your contribution |
Thank you for the reply. Sorry, i use a custom linter in my IDE i will remove it, close this pr and make a new simple a short one. |
No description provided.