Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Client.php #39

Merged
merged 1 commit into from
Aug 3, 2019
Merged

Update Client.php #39

merged 1 commit into from
Aug 3, 2019

Conversation

khvalov
Copy link
Contributor

@khvalov khvalov commented Aug 3, 2019

Fix for converting $channel / $client to String (if it defined as number) as it is expected by Centrifuge server

Fix for converting $channel / $client to String (if it defined as number) as  it is expected by Centrifuge server
@FZambia
Copy link
Member

FZambia commented Aug 3, 2019

Hello, I understand how user ID can be a number when passing to client functions. But can you explain why these 2 parameters can come as numbers?

@khvalov
Copy link
Contributor Author

khvalov commented Aug 3, 2019

Hi,
You can assign channel name as number (it's valid based on statement https://centrifugal.github.io/centrifugo/server/channels/

"Only ASCII symbols must be used in channel string."

For $client it's kind of confusion around server documentation - (https://centrifugal.github.io/centrifugo/server/private_channels/) - wasn't really clear which client ID supposed to use. I have proposed documentation update with more clarification on ClientID topic.
But here you are right - it's just impossible to get number only Client ID from Centrifuge server

@FZambia FZambia merged commit 0e26cf3 into centrifugal:master Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants