Add some backward compatibility for PHP 5.3 and 5.4 versions #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FZambia
reviewed
Aug 22, 2019
src/Client.php
Outdated
| * Function added for backward compatibility with PHP version < 5.5 | ||
| */ | ||
|
|
||
| private function json_last_error_msg() { |
There was a problem hiding this comment.
Do I understand right that PHP >5.4 will use this function too instead of native one?
|
Yes, you're right. Do you think it's better to create a wrapper function with function_exists() check? |
|
@Darkkin yes, just to inherit all changes from this function in new PHP versions and fallback to this one only on old PHP versions. |
|
Request updated. Please review added wrapper. |
FZambia
reviewed
Aug 24, 2019
src/Client.php
Outdated
|
|
||
| public function _json_last_error_msg() { | ||
| if (function_exists('json_last_error_msg')) { | ||
| return json_last_error_msg(json_last_error()); |
There was a problem hiding this comment.
Looking at https://www.php.net/manual/en/function.json-last-error-msg.php json_last_error_msg definition is:
json_last_error_msg ( void ) : stringHere you are calling it with argument json_last_error() - can you explain why?
There was a problem hiding this comment.
It's my mistake. Fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.