Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG/ENH: ctl run: log level handling #1239

Merged
1 commit merged into from
May 16, 2018
Merged

BUG/ENH: ctl run: log level handling #1239

1 commit merged into from
May 16, 2018

Conversation

ghost
Copy link

@ghost ghost commented May 16, 2018

fixes #1075
introduces new loglevel parameter

fixes #1075
introduces new loglevel parameter
@ghost ghost added bug Indicates an unexpected problem or unintended behavior component: intelmqctl labels May 16, 2018
@ghost ghost added this to the 1.0.5 milestone May 16, 2018
@ghost ghost requested a review from e3rd May 16, 2018 10:25
@codecov-io
Copy link

codecov-io commented May 16, 2018

Codecov Report

Merging #1239 into maintenance will decrease coverage by 0.01%.
The diff coverage is 36.36%.

@@               Coverage Diff               @@
##           maintenance    #1239      +/-   ##
===============================================
- Coverage        73.64%   73.63%   -0.02%     
===============================================
  Files              218      218              
  Lines             9406     9406              
  Branches          1285     1287       +2     
===============================================
- Hits              6927     6926       -1     
- Misses            2200     2201       +1     
  Partials           279      279
Impacted Files Coverage Δ
intelmq/lib/bot_debugger.py 18.96% <14.28%> (-1.38%) ⬇️
intelmq/bin/intelmqctl.py 11.09% <75%> (+0.12%) ⬆️

Copy link
Member

@e3rd e3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems good! Let's merge this.

It will be even better to add the parameter to bash-completion/intelmq.sh but this can be performed only after merging to develop branch. (Because in this state of repository, autocompletion is in an old state.)

@ghost
Copy link
Author

ghost commented May 16, 2018

Ad autocompletion: I agree. I'd like to have an automated solution, because maintaining it manually is hard.

@e3rd
Copy link
Member

e3rd commented May 16, 2018

Agree... but the only automated solution I imagine is to create an external library that takes intelmqctl.py, extracts all mentions of argparse and generates the intelmq.sh. But I don't dare to guess if that's an easy or a tough task.

@ghost
Copy link
Author

ghost commented May 16, 2018

-> #1240

@ghost ghost merged commit 08c5929 into maintenance May 16, 2018
@ghost ghost deleted the fix-1075 branch June 14, 2018 11:26
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: intelmqctl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants