too many levels of indirection in pointer passed to linkaddr_cmp #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_cmp Basically linkaddr_cmp consequently never returns true resulting in exessive traffic on the wireless network when packets targeted at the br are transmitted
dbjorklu
changed the title
|
Good catch ! There is actually the same error in eth_output() (that's what happens when you abuse casting) |
|
Yes, the type system is your friend :) Great to see it's in eth_output() as well, as I actually also observed On 10.05.2016 17:16, Laurent Deru wrote:
|
|
Merging it, I will look at a more robust filtering soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically linkaddr_cmp consequently never returns true resulting in
excessive traffic on the wireless network when packets targeted at the br
are transmitted