Skip to content

ENT-10961, CFE-1840: Added documentation on body fsattrs and the immutable constraint #3403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2025
Merged

ENT-10961, CFE-1840: Added documentation on body fsattrs and the immutable constraint #3403

merged 1 commit into from
Jul 4, 2025

Conversation

larsewi
Copy link
Contributor

@larsewi larsewi commented Mar 7, 2025

Ticket: ENT-10961, CFE-1840

nickanderson
nickanderson requested changes Mar 7, 2025
View reviewed changes
Copy link
Member

@nickanderson nickanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add history.

craigcomstock
craigcomstock approved these changes Mar 11, 2025
View reviewed changes
craigcomstock
craigcomstock requested changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@craigcomstock craigcomstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one typo

@larsewi larsewi force-pushed the immutable branch 4 times, most recently from cea8867 to f06bab9 Compare May 26, 2025 12:14
nickanderson
nickanderson approved these changes May 27, 2025
View reviewed changes
Copy link
Member

@nickanderson nickanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but a question about what it means to clear the immutable bit multiple times.

reference/promise-types/files.markdown Outdated
Comment on lines 2794 to 2795
as short as possible. The immutable bit may be temporarily cleared multiple
times during a files promise.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean that it might be cleared multiple times during a files promise? Like cleared, re-applied, cleared, re-applied?

Copy link
Contributor Author

@larsewi larsewi May 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I mean is that if you have a file promise that for example contains both the content and the perms attribute. Then the immutable bit may be temporarily cleared while changing the perms and reapplied afterwards. Later when replacing $(this.promiser) with $(this.promiser).cfnew (containing new content) it may again be temporarily cleared and reapplied.

@larsewi @nickanderson
Added documentation on body fsattrs and the immutable constraint
66f9f15 
Ticket: ENT-10961, CFE-1840
Signed-off-by: Lars Erik Wik <[email protected]>
Co-authored-by: Nick Anderson <[email protected]>
@olehermanse
Copy link
Member

@cf-bottom jenkins, please

@cf-bottom
Copy link

Alright, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/142/

Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-142/output/_site/

@olehermanse olehermanse merged commit 2cedf66 into cfengine:master Jul 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickanderson nickanderson nickanderson approved these changes

@craigcomstock craigcomstock craigcomstock approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@larsewi @olehermanse @cf-bottom @nickanderson @craigcomstock