Skip to content

Commit

Permalink
core: remove unused dataAsRow flag from LDA
Browse files Browse the repository at this point in the history
  • Loading branch information
berak committed Jul 15, 2018
1 parent 80770aa commit 4382bdc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion modules/core/include/opencv2/core.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -2585,7 +2585,6 @@ class CV_EXPORTS LDA
static Mat subspaceReconstruct(InputArray W, InputArray mean, InputArray src);

protected:
bool _dataAsRow; // unused, but needed for 3.0 ABI compatibility.
int _num_components;
Mat _eigenvectors;
Mat _eigenvalues;
Expand Down
4 changes: 2 additions & 2 deletions modules/core/src/lda.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -996,9 +996,9 @@ void eigenNonSymmetric(InputArray _src, OutputArray _evals, OutputArray _evects)
// Linear Discriminant Analysis implementation
//------------------------------------------------------------------------------

LDA::LDA(int num_components) : _dataAsRow(true), _num_components(num_components) { }
LDA::LDA(int num_components) : _num_components(num_components) { }

LDA::LDA(InputArrayOfArrays src, InputArray labels, int num_components) : _dataAsRow(true), _num_components(num_components)
LDA::LDA(InputArrayOfArrays src, InputArray labels, int num_components) : _num_components(num_components)
{
this->compute(src, labels); //! compute eigenvectors and eigenvalues
}
Expand Down

0 comments on commit 4382bdc

Please sign in to comment.