fix: border issue on GIFs where terminal height does not match perfec…

…tly with pixel height (rows)
charmbracelet · Oct 20, 2022 · 045bd7e · 045bd7e
1 parent 26f01da
commit 045bd7e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/examples/commands/arrow.gif b/examples/commands/arrow.gif
diff --git a/video.go b/video.go
@@ -73,10 +73,11 @@ func MakeGIF(opts VideoOptions) *exec.Cmd {
 		"-framerate", fmt.Sprint(opts.Framerate),
 		"-i", opts.Input+cursorFrameFormat,
 		"-filter_complex",
-		fmt.Sprintf(`[0][1]overlay[merged];[merged]scale=%d:%d[scaled];[scaled]pad=width=%d:height=%d:x=%d:y=%d[padded];[padded]fillborders=left=%d:right=%d:top=%d:bottom=%d:mode=fixed:color=%s[bordered];[bordered]split[a][b];[a]palettegen=max_colors=256[p];[b][p]paletteuse[out]`,
-			opts.Width-2*opts.Padding, opts.Height-2*opts.Padding,
+		fmt.Sprintf(`[0][1]overlay[merged];[merged]scale=%d:-1[scaled];[scaled]pad=%d:%d:(ow-iw)/2:(oh-ih)/2:%s[padded];[padded]fillborders=left=%d:right=%d:top=%d:bottom=%d:mode=fixed:color=%s[bordered];[bordered]split[a][b];[a]palettegen=max_colors=256[p];[b][p]paletteuse[out]`,
+			opts.Width-2*opts.Padding,
 			opts.Width, opts.Height,
-			opts.Padding, opts.Padding, opts.Padding, opts.Padding, opts.Padding, opts.Padding,
+			opts.BackgroundColor,
+			opts.Padding, opts.Padding, opts.Padding, opts.Padding,
 			opts.BackgroundColor,
 		),
 		"-map", "[out]",