Skip to content

Commit

Permalink
Fix CI process to only depend on tests with latest stable Go
Browse files Browse the repository at this point in the history
We don't test with Go 1.15 at the moment because if using go:embed. The test-prev check is still here, but it is disabled and nothing depends on it. This will be the state until Go 1.17 is released and we can switch test-prev to 1.16. And even then, the build probably shouldn't depend on test-prev, its failure should be only informative, not aborting the whole CI.
  • Loading branch information
na-- committed Jun 29, 2021
1 parent da4c8c6 commit cc0361c
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/all.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
echo "Base revision: $BASEREV"
golangci-lint run --out-format=tab --new-from-rev "$BASEREV" ./...
test:
test-prev:
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -113,7 +113,7 @@ jobs:
args=("-p" "2" "-race")
go test "${args[@]}" -timeout 800s ./...
test-cov:
test-current-cov:
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -181,7 +181,7 @@ jobs:
build:
runs-on: ubuntu-latest
needs: [configure, deps, lint, test, test-cov]
needs: [configure, deps, lint, test-current-cov]
if: startsWith(github.ref, 'refs/tags/v')
env:
VERSION: ${{ needs.configure.outputs.version }}
Expand Down Expand Up @@ -242,7 +242,7 @@ jobs:

build-docker:
runs-on: ubuntu-latest
needs: [deps, lint, test, test-cov, configure]
needs: [deps, lint, test-current-cov, configure]
env:
VERSION: ${{ needs.configure.outputs.version }}
steps:
Expand Down Expand Up @@ -300,7 +300,7 @@ jobs:
defaults:
run:
shell: powershell
needs: [deps, lint, test, test-cov, configure, build]
needs: [deps, lint, test-current-cov, configure, build]
if: startsWith(github.ref, 'refs/tags/v')
env:
VERSION: ${{ needs.configure.outputs.version }}
Expand Down Expand Up @@ -369,7 +369,7 @@ jobs:
# Disabled until #1997 and #1998 are addressed.
# publish-macos:
# runs-on: macos-latest
# needs: [deps, lint, test, test-cov, configure, build]
# needs: [deps, lint, test-current-cov, configure, build]
# if: startsWith(github.ref, 'refs/tags/v')
# env:
# VERSION: ${{ needs.configure.outputs.version }}
Expand All @@ -387,7 +387,7 @@ jobs:

publish-github:
runs-on: ubuntu-latest
needs: [configure, deps, lint, test, test-cov, build, package-windows]
needs: [configure, deps, lint, test-current-cov, build, package-windows]
if: startsWith(github.ref, 'refs/tags/v')
env:
VERSION: ${{ needs.configure.outputs.version }}
Expand Down

0 comments on commit cc0361c

Please sign in to comment.