Skip to content

Commit

Permalink
engicam: imx6: migrate to DM_SERIAL
Browse files Browse the repository at this point in the history
Add the needed DT overrides and configs to enable UART in SPL.

Cc: Fabio Estevam <[email protected]>
Signed-off-by: Michael Trimarchi <[email protected]>
Tested-by: Suniel Mahesh <[email protected]>
Reviewed-by: Fabio Estevam <[email protected]>
  • Loading branch information
panicking authored and sbabic committed Jan 31, 2023
1 parent 4aae15d commit 6dac63a
Show file tree
Hide file tree
Showing 9 changed files with 41 additions and 17 deletions.
16 changes: 16 additions & 0 deletions arch/arm/dts/imx6qdl-icore-u-boot.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,22 @@

#include "imx6qdl-u-boot.dtsi"

&soc {
u-boot,dm-pre-reloc;
};

&aips1 {
u-boot,dm-pre-reloc;
};

&pinctrl_uart4 {
u-boot,dm-pre-reloc;
};

&uart4 {
u-boot,dm-pre-reloc;
};

&usdhc1 {
u-boot,dm-spl;
};
Expand Down
16 changes: 16 additions & 0 deletions arch/arm/dts/imx6ul-isiot-u-boot.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,22 @@

#include "imx6ul-u-boot.dtsi"

&soc {
u-boot,dm-pre-reloc;
};

&aips1 {
u-boot,dm-pre-reloc;
};

&pinctrl_uart1 {
u-boot,dm-pre-reloc;
};

&uart1 {
u-boot,dm-pre-reloc;
};

&usdhc1 {
u-boot,dm-spl;
};
Expand Down
20 changes: 3 additions & 17 deletions board/engicam/common/spl.c
Original file line number Diff line number Diff line change
Expand Up @@ -26,20 +26,6 @@
#include <asm/mach-imx/iomux-v3.h>
#include <asm/mach-imx/video.h>

#define UART_PAD_CTRL (PAD_CTL_PKE | PAD_CTL_PUE | \
PAD_CTL_PUS_100K_UP | PAD_CTL_SPEED_MED | \
PAD_CTL_DSE_40ohm | PAD_CTL_SRE_FAST | PAD_CTL_HYS)

static iomux_v3_cfg_t const uart_pads[] = {
#ifdef CONFIG_MX6QDL
IOMUX_PADS(PAD_KEY_COL0__UART4_TX_DATA | MUX_PAD_CTRL(UART_PAD_CTRL)),
IOMUX_PADS(PAD_KEY_ROW0__UART4_RX_DATA | MUX_PAD_CTRL(UART_PAD_CTRL)),
#elif CONFIG_MX6UL
IOMUX_PADS(PAD_UART1_TX_DATA__UART1_DCE_TX | MUX_PAD_CTRL(UART_PAD_CTRL)),
IOMUX_PADS(PAD_UART1_RX_DATA__UART1_DCE_RX | MUX_PAD_CTRL(UART_PAD_CTRL)),
#endif
};

#ifdef CONFIG_SPL_LOAD_FIT
int board_fit_config_name_match(const char *name)
{
Expand Down Expand Up @@ -421,12 +407,12 @@ void board_init_f(ulong dummy)
if (!(is_mx6ul()))
gpr_init();

/* iomux */
SETUP_IOMUX_PADS(uart_pads);

/* setup GP timer */
timer_init();

/* Enable device tree and early DM support*/
spl_early_init();

/* UART clocks enabled and gd valid - init serial console */
preloader_console_init();

Expand Down
1 change: 1 addition & 0 deletions configs/imx6dl_icore_nand_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ CONFIG_FEC_MXC=y
CONFIG_MII=y
CONFIG_PINCTRL=y
CONFIG_PINCTRL_IMX6=y
CONFIG_DM_SERIAL=y
CONFIG_MXC_UART=y
CONFIG_IMX_THERMAL=y
CONFIG_VIDEO=y
Expand Down
1 change: 1 addition & 0 deletions configs/imx6q_icore_nand_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ CONFIG_FEC_MXC=y
CONFIG_MII=y
CONFIG_PINCTRL=y
CONFIG_PINCTRL_IMX6=y
CONFIG_DM_SERIAL=y
CONFIG_MXC_UART=y
CONFIG_IMX_THERMAL=y
CONFIG_VIDEO=y
Expand Down
1 change: 1 addition & 0 deletions configs/imx6qdl_icore_mipi_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -74,5 +74,6 @@ CONFIG_FEC_MXC=y
CONFIG_MII=y
CONFIG_PINCTRL=y
CONFIG_PINCTRL_IMX6=y
CONFIG_DM_SERIAL=y
CONFIG_MXC_UART=y
CONFIG_IMX_THERMAL=y
1 change: 1 addition & 0 deletions configs/imx6qdl_icore_mmc_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ CONFIG_FEC_MXC=y
CONFIG_MII=y
CONFIG_PINCTRL=y
CONFIG_PINCTRL_IMX6=y
CONFIG_DM_SERIAL=y
CONFIG_MXC_UART=y
CONFIG_IMX_THERMAL=y
CONFIG_VIDEO=y
Expand Down
1 change: 1 addition & 0 deletions configs/imx6qdl_icore_nand_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ CONFIG_FEC_MXC=y
CONFIG_MII=y
CONFIG_PINCTRL=y
CONFIG_PINCTRL_IMX6=y
CONFIG_DM_SERIAL=y
CONFIG_MXC_UART=y
CONFIG_IMX_THERMAL=y
CONFIG_VIDEO=y
Expand Down
1 change: 1 addition & 0 deletions configs/imx6qdl_icore_rqs_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -72,4 +72,5 @@ CONFIG_FEC_MXC=y
CONFIG_MII=y
CONFIG_PINCTRL=y
CONFIG_PINCTRL_IMX6=y
CONFIG_DM_SERIAL=y
CONFIG_MXC_UART=y

0 comments on commit 6dac63a

Please sign in to comment.