Use references to serialize dpe response in InvokeDpe #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clundin25
force-pushed
the
invoke-resp-zerocopy
branch
2 times, most recently
from
71eef4f to
f088ce1
Compare
This saves 6272 bytes on the stack.
clundin25
force-pushed
the
invoke-resp-zerocopy
branch
from
f088ce1 to
0527869
Compare
clundin25
commented
Feb 21, 2025
Comment on lines
-157
to
+168
| Response::Error(ResponseHdr::new(e)) | ||
| let r = ResponseHdr::try_mut_from_bytes( |
There was a problem hiding this comment.
Since Response::Error::as_bytes calls the inner ResponseHdr::as_bytes the data being serialized has not changed.
clundin25
requested review from
jhand2,
fdamato,
rusty1968,
bluegate010,
mhatrevi,
swenson and
vsonims
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use references to serialize dpe response in InvokeDpe
This saves 6272 bytes on the stack.