Skip to content

Commit

Permalink
Merge pull request jumpserver#3921 from jumpserver/dev
Browse files Browse the repository at this point in the history
Dev
  • Loading branch information
BaiJiangJie authored Apr 18, 2020
2 parents 5677bf0 + 0379e51 commit cc30a20
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 13 deletions.
2 changes: 1 addition & 1 deletion apps/assets/models/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def unknown(cls):
return cls(cls.UNKNOWN, timezone.now())

@classmethod
def set(cls, key, value, ttl=0):
def set(cls, key, value, ttl=None):
cache.set(key, value, ttl)

@classmethod
Expand Down
13 changes: 7 additions & 6 deletions apps/orgs/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@ def get_instance(cls, id_or_name, default=False):
org = cls.default() if default else None
return org

@lazyproperty
# @lazyproperty
# lazyproperty 导致用户列表中角色显示出现不稳定的情况, 如果不加会导致数据库操作次数太多
def org_users(self):
from users.models import User
if self.is_real():
Expand All @@ -83,17 +84,17 @@ def org_users(self):
return users

def get_org_users(self):
return self.org_users
return self.org_users()

@lazyproperty
# @lazyproperty
def org_admins(self):
from users.models import User
if self.is_real():
return self.admins.all()
return User.objects.filter(role=User.ROLE_ADMIN)

def get_org_admins(self):
return self.org_admins
return self.org_admins()

def org_id(self):
if self.is_real():
Expand All @@ -103,15 +104,15 @@ def org_id(self):
else:
return ''

@lazyproperty
# @lazyproperty
def org_auditors(self):
from users.models import User
if self.is_real():
return self.auditors.all()
return User.objects.filter(role=User.ROLE_AUDITOR)

def get_org_auditors(self):
return self.org_auditors
return self.org_auditors()

def get_org_members(self, exclude=()):
from users.models import User
Expand Down
7 changes: 1 addition & 6 deletions apps/users/api/user.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,7 @@ def perform_create(self, serializer):
if isinstance(users, User):
users = [users]
if current_org and current_org.is_real():
# current_org.users.add(*users)
# 如果在真实组织下创建用户,使用上面的语句会出现用户角色显示不稳定的问题
# 可能是current_org的users add操作是进程不安全的
# User Model 中的 remove 操作没有出现问题,暂时不做更改
for user in users:
user.related_user_orgs.add(current_org.id)
current_org.users.add(*users)
self.send_created_signal(users)

def get_permissions(self):
Expand Down

0 comments on commit cc30a20

Please sign in to comment.