Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the isInline property to create inline table #42

Merged
merged 2 commits into from
Apr 10, 2023

Conversation

PinYuanChen
Copy link
Contributor

According to the official document, there is a field called is_inline to distinguish whether the database appears in the page as an inline block.
I add this property to the DatabaseCreateRequest for users to create an inline table. I set the default value to false so it won't break the code.

@chojnac
Copy link
Owner

chojnac commented Mar 16, 2023

Not sure if this will work, there is no mention of is_inline in the "Create a database" endpoint description.
Also this property should be added to the Database entity.

@PinYuanChen
Copy link
Contributor Author

I've tried it by myself and it can successfully create an inline table in the designated page.
You can try it by yourself and make sure it works.
Besides, I also add this property to the Database entity.

@chojnac chojnac merged commit cf08a27 into chojnac:main Apr 10, 2023
@PinYuanChen PinYuanChen deleted the P/inline-database branch May 17, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants