Skip to content

Commit

Permalink
remove the bitvec input type
Browse files Browse the repository at this point in the history
bitvec integration has caused some dependency issues, that were solved,
but still raises the minimum rust version significantly, which will be
problematic for some distributions like Debian.

The input traits implementations for bitvec types have been moved to the
nom-bitvec crate, so we can keep the functionality without affecting
basic nom usage
  • Loading branch information
Geal committed Jul 25, 2021
1 parent e9ba351 commit a59ff75
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 364 deletions.
8 changes: 0 additions & 8 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -30,19 +30,11 @@ include = [
[features]
alloc = []
std = ["alloc", "memchr/use_std"]
bitvec-base = ["bitvec"]
bitvec-alloc = ["alloc", "bitvec/alloc"]
bitvec-std = ["bitvec/std", "std"]
default = ["std", "lexical"]
regexp = ["regex"]
lexical = ["lexical-core"]
docsrs = []

[dependencies.bitvec]
version = ">= 0.22.3"
optional = true
default-features = false

[dependencies.regex]
version = "^1.0"
optional = true
Expand Down
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,6 @@ Some benchmarks are available on [Github](https://github.com/Geal/nom_benchmarks

The 6.0 series of nom requires **Rustc version 1.44 or greater**, but it can change for some feature combinations:
- compatible with 1.41.1 if building without the `alloc` or `std` features, ie `--no-default-features --features="regex,lexical"`
- compatible with 1.51 if using the bitvec features

Travis CI always has a build with a pinned version of Rustc matching the oldest supported Rust release.
The current policy is that this will only be updated in the next major nom release.
Expand Down
2 changes: 0 additions & 2 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -411,8 +411,6 @@
#[cfg(feature = "alloc")]
#[macro_use]
extern crate alloc;
#[cfg(feature = "bitvec")]
pub extern crate bitvec;
#[cfg(doctest)]
extern crate doc_comment;
#[cfg(feature = "lexical")]
Expand Down
Loading

0 comments on commit a59ff75

Please sign in to comment.