Skip to content

Commit

Permalink
DOC: Ensure basic flake8 diff checks only Python (pandas-dev#15769)
Browse files Browse the repository at this point in the history
Follow-up to pandas-devgh-15749
  • Loading branch information
gfyoung authored and jreback committed Mar 21, 2017
1 parent aa9d0cf commit 19c8032
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes ``git diff upstream/master | flake8 --diff``
- [ ] passes ``git diff upstream/master --name-only -- '*.py' | flake8 --diff``
- [ ] whatsnew entry
2 changes: 1 addition & 1 deletion doc/source/contributing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,7 @@ Travis-CI will run the `flake8 <http://pypi.python.org/pypi/flake8>`_ tool
and report any stylistic errors in your code. Therefore, it is helpful before
submitting code to run the check yourself on the diff::

git diff master | flake8 --diff
git diff master --name-only -- '*.py' | flake8 --diff

This command will catch any stylistic errors in your changes specifically, but
be beware it may not catch all of them. For example, if you delete the only
Expand Down

0 comments on commit 19c8032

Please sign in to comment.