Skip to content

Commit

Permalink
pkgbase: Move headers and libs out of runtime and utilities
Browse files Browse the repository at this point in the history
Headers from src/include were in the runtime-dev package but
subdirectories of src/include ended up in utilities-dev by default.
Neither package is a good choice - the headers in src/include are not
useful without the libraries contained in clibs-dev.

This moves the standard C headers to clibs-dev (C++ headers are already
in this package). While working on this, I found that various clang
libraries and headers were also bundled into utilities-dev by default
so these are also moved to clang-dev.

I also added a FreeBSD-build-essential meta package to make it simple to
install all the toolchain parts.

PR:		254173
Reviewed byb:	manu
MFC after:	1 week
Differential Revision: https://reviews.freebsd.org/D41815
  • Loading branch information
Doug Rabson authored and Doug Rabson committed Sep 12, 2023
1 parent d0266fb commit 78847e1
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 1 deletion.
2 changes: 1 addition & 1 deletion include/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

.include <src.opts.mk>

PACKAGE=runtime
PACKAGE=clibs
CLEANFILES= osreldate.h version
SUBDIR= arpa protocols rpcsvc rpc xlocale
.if ${MACHINE_CPUARCH} == "amd64"
Expand Down
2 changes: 2 additions & 0 deletions include/Makefile.inc
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Make sure all our subdirectory headers end up in clibs-dev
PACKAGE=clibs
1 change: 1 addition & 0 deletions lib/clang/Makefile.inc
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@

.include <bsd.compiler.mk>

PACKAGE= clang
MK_PIE:= no # Explicit libXXX.a references

.if ${COMPILER_TYPE} == "clang"
Expand Down
1 change: 1 addition & 0 deletions lib/csu/Makefile.inc
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
PACKAGE= clibs-dev

NO_WMISSING_VARIABLE_DECLARATIONS=
# Can't instrument these files since that breaks non-sanitized programs.
Expand Down
1 change: 1 addition & 0 deletions lib/libclang_rt/Makefile.inc
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@

.include <bsd.compiler.mk>

PACKAGE= clang
CRTSRC= ${SRCTOP}/contrib/llvm-project/compiler-rt
.include "compiler-rt-vars.mk"

Expand Down
3 changes: 3 additions & 0 deletions release/packages/generate-ucl.sh
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ main() {
certctl)
pkgdeps="caroot openssl"
;;
clang)
pkgdeps="lld clang-dev libcompiler_rt-dev"
;;

# -dev packages that have no corresponding non-dev package
# as a dependency.
Expand Down

0 comments on commit 78847e1

Please sign in to comment.