Chrivers/gradient support #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrivers
force-pushed
the
chrivers/gradient-support
branch
2 times, most recently
from
2f3721a to
119c41f
Compare
…ally identical) EndpointLink type
… "Zigbee2MQTT" prefix)
… it is not guaranteed to be a string by z2m
…interval to i64 just to be sure
…troduce ExposeBase, which corresponds to the Base class in z2m, and extend from there.
…d when going through data
…ues to u8 (for color operations)
…m Thomas Lochmatter
… Adobe RGB color space for now)
…me per-class rules for handling
… with older rust versions
chrivers
force-pushed
the
chrivers/gradient-support
branch
from
119c41f to
76bfebc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the first, experimental support for Gradient Lights!
Support for this is pretty involved, and requires somewhat complicated math to do color space conversion between XYZ, XYY and RGB.
Some artifacts are expected, and so far this has only been tested with a single hue led strip, the LCX005 ("Hue Light Strip for PC").
Feedback very welcome. Please let me know if this works for you, and which lights you have tried this on :)