Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] BF writer support reads #3031

Merged
merged 5 commits into from
Nov 13, 2024
Merged

[ENH] BF writer support reads #3031

merged 5 commits into from
Nov 13, 2024

Conversation

sanketkedia
Copy link
Contributor

@sanketkedia sanketkedia commented Oct 30, 2024

Description of changes

Summarize the changes made by this PR.

  • New functionality
    • Implemented writer.get_clone() that returns an owned value for the key

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

@sanketkedia sanketkedia marked this pull request as ready for review October 30, 2024 01:55
Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@sanketkedia sanketkedia changed the title writer.get support [ENH] BF writer support reads Oct 30, 2024
@sanketkedia sanketkedia requested a review from HammadB October 30, 2024 03:14
@sanketkedia sanketkedia force-pushed the 10-29-writer.get_support branch 2 times, most recently from 8c3ddcc to bc48745 Compare November 11, 2024 06:32
@sanketkedia sanketkedia force-pushed the 10-29-writer.get_support branch from c2b4b85 to f70ef34 Compare November 13, 2024 21:25
@sanketkedia sanketkedia changed the base branch from 10-22-spann_staging to graphite-base/3031 November 13, 2024 22:10
@sanketkedia sanketkedia force-pushed the 10-29-writer.get_support branch from 2794417 to fb17ddf Compare November 13, 2024 22:10
@sanketkedia sanketkedia changed the base branch from graphite-base/3031 to main November 13, 2024 22:11
@sanketkedia sanketkedia force-pushed the 10-29-writer.get_support branch from fb17ddf to 997c9ac Compare November 13, 2024 22:11
Copy link
Contributor Author

sanketkedia commented Nov 13, 2024

Merge activity

  • Nov 13, 5:14 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 13, 5:14 PM EST: A user merged this pull request with Graphite.

@sanketkedia sanketkedia merged commit 50a2220 into main Nov 13, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants