Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add crypto-js for the case of missing crypto.subtle in the browser #3267

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sparkleholic
Copy link

Description of changes

crypto.subtle is avaiable if the browser open the browser example in localhost or 127.0.0.1. But it is not available if the browser open the browser example in other ip address. So we need to add crypto-js for the case of missing crypto.subtle in the browser.

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • crypto.subtle is available when accessed via localhost or 127.0.0.1, but not on other IP, so crypto-js should be added as a fallback.

Test plan

How are these changes tested?

  • run browser example on the remote pc, and open browser ip:3000

Documentation Changes

  • N/A

Copy link

github-actions bot commented Dec 9, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

crypto.subtle is avaiable if the browser open the browser example in
localhost or 127.0.0.1. But it is not available if the browser open the
browser example in other ip address. So we need to add crypto-js for the
case of missing crypto.subtle in the browser.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant