Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH]: move materialization into operator #3357

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

codetheweb
Copy link
Contributor

@codetheweb codetheweb commented Dec 26, 2024

Description of changes

Log materialization is now in its own operator. Having materialization in its own operator unlocks two main benefits:

  • allows us to pipeline log applications across segment types (currently unrealized)
  • we can easily bail for any partition with an empty set of materialized records before constructing writers

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Tested locally with SciDocs as well.

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

UnintializedWriter,
ApplyMaterializedLogsErrorMetadataSegment(#[from] MetadataSegmentError),
#[error("Uninitialized writer")]
UninitializedWriter,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

misspelling fixes

@codetheweb codetheweb force-pushed the feat-materialize-operator-2 branch from c8fca26 to 500bf8a Compare December 26, 2024 18:34
@codetheweb codetheweb marked this pull request as ready for review December 26, 2024 20:56
@codetheweb codetheweb force-pushed the feat-materialize-operator-2 branch from 19db990 to 99780f2 Compare December 26, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant