Skip to content

Commit

Permalink
Updating to 101.0.4936.1_10.1.94 definitions
Browse files Browse the repository at this point in the history
  • Loading branch information
@kenshaw
kenshaw committed Mar 10, 2022
1 parent 892afa7 commit 0e2f465
Show file tree
Hide file tree
Showing 4 changed files with 488 additions and 311 deletions.
3 changes: 3 additions & 0 deletions audits/types.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 11 additions & 9 deletions css/css.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

3 comments on commit 0e2f465

@alexd-conf
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to install chromedp tonight and the installation failed. The error was "query.go:1139:8: assignment mismatch: 7 variables but css.GetMatchedStylesForNode(nodes[0].NodeID).Do returns 8 values".
The modified file css/css.go for this commit breaks the file at https://github.com/chromedp/chromedp/blob/master/query.go#L1125, for the related chromedp project.
The problem is that the GetMatchedStylesForNodeReturns now have an additional value, InheritedPseudoElements. Having 8 properties breaks the above chromedp/query.go file because it expects GetMatchedStylesForNodeReturns to have 7 properties.

@puppywang
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue here, hope to fix soon, thanks.

@ZekeLu
Copy link
Member

@ZekeLu ZekeLu commented on 0e2f465 Mar 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexd-conf @puppywang See chromedp/chromedp#1031

Please sign in to comment.