Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output a curl command for debugging. #123

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

Output a curl command for debugging. #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion response.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package hstspreload

import (
"errors"
"fmt"
"net/http"
"net/url"
)
Expand All @@ -12,10 +13,14 @@ func checkSingleHeader(resp *http.Response) (header *string, issues Issues) {

switch {
case len(hstsHeaders) == 0:
curlInfo := ""
if resp.Request != nil {
curlInfo = fmt.Sprintf(" Check that the following terminal command outputs `Strict-Transport-Security`: curl -I \"%v\"", resp.Request.URL)
}
return nil, issues.addErrorf(
"response.no_header",
"No HSTS header",
"Response error: No HSTS header is present on the response.")
"Response error: No HSTS header is present on the response.%s", curlInfo)

case len(hstsHeaders) > 1:
// TODO: Give feedback on the first(last?) HSTS header?
Expand Down