Sort the pinsets and add logging for debugging. #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you close this intentionally? |
|
Reopened in case you want to merge this. I'll update this PR so that the hashes of the pins are printed in alphabetic order as well. |
|
Thanks! |
MXEBot
pushed a commit
to mirror/chromium
that referenced
this pull request
Dec 14, 2016
This tool is a C++ port of the Go script [1] currently used to generate the static (preloaded) domain security state (net/http/transport_security_state_static.h) blob. A follow up CL [2] integrates this script into the build process. This scripts generates identical outputs as the Go script after merging [3]. The only difference should be related to whitespace and comments. You can run the script manually: out/Default/domain_security_preload_generator net/http/transport_security_state_static.json net/http/transport_security_state_static.pins net/tools/domain_security_preload_generator/resources/transport_security_state_static.template /home/you/output.h -v [1] https://github.com/chromium/hstspreload/blob/master/cmd/transport_security_state_static_generate/transport_security_state_static_generate.go [2] https://codereview.chromium.org/2551943002 [3] chromium/hstspreload#91 BUG=595493 [email protected], [email protected] Review-Url: https://codereview.chromium.org/2551153003 . Cr-Commit-Position: refs/heads/master@{#438316}
MXEBot
pushed a commit
to mirror/chromium
that referenced
this pull request
Dec 14, 2016
This tool is a C++ port of the Go script [1] currently used to generate the static (preloaded) domain security state (net/http/transport_security_state_static.h) blob. A follow up CL [2] integrates this tool into the build process. This tool generates identical outputs as the Go script after merging [3]. The only difference should be related to whitespace and comments. You can run the tool manually: out/Default/domain_security_preload_generator net/http/transport_security_state_static.json net/http/transport_security_state_static.pins net/tools/domain_security_preload_generator/resources/transport_security_state_static.template /home/you/output.h -v [1] https://github.com/chromium/hstspreload/blob/master/cmd/transport_security_state_static_generate/transport_security_state_static_generate.go [2] https://codereview.chromium.org/2551943002 [3] chromium/hstspreload#91 BUG=595493 [email protected], [email protected] Committed: https://chromium.googlesource.com/chromium/src/+/09983e3dcc7573863a52ef827870613dde3cd83e Review-Url: https://codereview.chromium.org/2551153003 Cr-Commit-Position: refs/heads/master@{#438358}
jelmansouri
pushed a commit
to jelmansouri/chromium-net
that referenced
this pull request
Mar 7, 2017
This tool is a C++ port of the Go script [1] currently used to generate the static (preloaded) domain security state (net/http/transport_security_state_static.h) blob. A follow up CL [2] integrates this script into the build process. This scripts generates identical outputs as the Go script after merging [3]. The only difference should be related to whitespace and comments. You can run the script manually: out/Default/domain_security_preload_generator net/http/transport_security_state_static.json net/http/transport_security_state_static.pins net/tools/domain_security_preload_generator/resources/transport_security_state_static.template /home/you/output.h -v [1] https://github.com/chromium/hstspreload/blob/master/cmd/transport_security_state_static_generate/transport_security_state_static_generate.go [2] https://codereview.chromium.org/2551943002 [3] chromium/hstspreload#91 BUG=595493 [email protected], [email protected] Review-Url: https://codereview.chromium.org/2551153003 . Cr-Original-Commit-Position: refs/heads/master@{#438316} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 09983e3dcc7573863a52ef827870613dde3cd83e
jelmansouri
pushed a commit
to jelmansouri/chromium-net
that referenced
this pull request
Mar 7, 2017
This tool is a C++ port of the Go script [1] currently used to generate the static (preloaded) domain security state (net/http/transport_security_state_static.h) blob. A follow up CL [2] integrates this tool into the build process. This tool generates identical outputs as the Go script after merging [3]. The only difference should be related to whitespace and comments. You can run the tool manually: out/Default/domain_security_preload_generator net/http/transport_security_state_static.json net/http/transport_security_state_static.pins net/tools/domain_security_preload_generator/resources/transport_security_state_static.template /home/you/output.h -v [1] https://github.com/chromium/hstspreload/blob/master/cmd/transport_security_state_static_generate/transport_security_state_static_generate.go [2] https://codereview.chromium.org/2551943002 [3] chromium/hstspreload#91 BUG=595493 [email protected], [email protected] Committed: https://chromium.googlesource.com/chromium/src/+/09983e3dcc7573863a52ef827870613dde3cd83e Review-Url: https://codereview.chromium.org/2551153003 Cr-Original-Commit-Position: refs/heads/master@{#438358} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 40db4b769e07e2e2a7ccbdcf5a8d734a1385c32b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not intended to be merged, this PR is just easier to link to.
These changes are for debugging and testing. Sorting the pinsets mimics the behaviour of having them in an
std::map. Having the pinsets in different order would result in different pinset IDs, which results in a different trie output, sorting them solves that and makes testing easier.