Skip to content

Commit

Permalink
Deprecating AbsoluteCaptureTimeReceiver
Browse files Browse the repository at this point in the history
Bug: chromium:1056230, webrtc:10739
Change-Id: I42b6a6f1c61eaaa468898a09bb7add30f0a419fb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/223065
Reviewed-by: Danil Chapovalov <[email protected]>
Commit-Queue: Minyue Li <[email protected]>
Cr-Commit-Position: refs/heads/master@{#34357}
  • Loading branch information
minyuel authored and WebRTC LUCI CQ committed Jun 22, 2021
1 parent 3f7b717 commit 6e65f6a
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 86 deletions.
2 changes: 0 additions & 2 deletions modules/rtp_rtcp/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,6 @@ rtc_library("rtp_rtcp") {
"include/ulpfec_receiver.h",
"source/absolute_capture_time_interpolator.cc",
"source/absolute_capture_time_interpolator.h",
"source/absolute_capture_time_receiver.cc", # DEPRECATED
"source/absolute_capture_time_receiver.h", # DEPRECATED
"source/absolute_capture_time_sender.cc",
"source/absolute_capture_time_sender.h",
"source/active_decode_targets_helper.cc",
Expand Down
41 changes: 0 additions & 41 deletions modules/rtp_rtcp/source/absolute_capture_time_receiver.cc

This file was deleted.

39 changes: 0 additions & 39 deletions modules/rtp_rtcp/source/absolute_capture_time_receiver.h

This file was deleted.

8 changes: 4 additions & 4 deletions modules/rtp_rtcp/source/absolute_capture_time_sender.cc
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

#include <limits>

#include "modules/rtp_rtcp/source/absolute_capture_time_receiver.h"
#include "modules/rtp_rtcp/source/absolute_capture_time_interpolator.h"
#include "system_wrappers/include/ntp_time.h"

namespace webrtc {
Expand All @@ -26,7 +26,7 @@ constexpr TimeDelta AbsoluteCaptureTimeSender::kInterpolationMaxInterval;
constexpr TimeDelta AbsoluteCaptureTimeSender::kInterpolationMaxError;

static_assert(
AbsoluteCaptureTimeReceiver::kInterpolationMaxInterval >=
AbsoluteCaptureTimeInterpolator::kInterpolationMaxInterval >=
AbsoluteCaptureTimeSender::kInterpolationMaxInterval,
"Receivers should be as willing to interpolate timestamps as senders.");

Expand All @@ -36,7 +36,7 @@ AbsoluteCaptureTimeSender::AbsoluteCaptureTimeSender(Clock* clock)
uint32_t AbsoluteCaptureTimeSender::GetSource(
uint32_t ssrc,
rtc::ArrayView<const uint32_t> csrcs) {
return AbsoluteCaptureTimeReceiver::GetSource(ssrc, csrcs);
return AbsoluteCaptureTimeInterpolator::GetSource(ssrc, csrcs);
}

absl::optional<AbsoluteCaptureTime> AbsoluteCaptureTimeSender::OnSendPacket(
Expand Down Expand Up @@ -108,7 +108,7 @@ bool AbsoluteCaptureTimeSender::ShouldSendExtension(

// Should if interpolation would introduce too much error.
const uint64_t interpolated_absolute_capture_timestamp =
AbsoluteCaptureTimeReceiver::InterpolateAbsoluteCaptureTimestamp(
AbsoluteCaptureTimeInterpolator::InterpolateAbsoluteCaptureTimestamp(
rtp_timestamp, rtp_clock_frequency, last_rtp_timestamp_,
last_absolute_capture_timestamp_);
const int64_t interpolation_error_ms = UQ32x32ToInt64Ms(std::min(
Expand Down

0 comments on commit 6e65f6a

Please sign in to comment.