Skip to content

Commit

Permalink
Use backticks not vertical bars to denote variables in comments for /…
Browse files Browse the repository at this point in the history
…modules/utility

Bug: webrtc:12338
Change-Id: I8900efa25a5eebcf57ec894108e1212e1d5b8089
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227098
Reviewed-by: Harald Alvestrand <[email protected]>
Commit-Queue: Artem Titov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#34675}
  • Loading branch information
Artem Titov authored and WebRTC LUCI CQ committed Aug 9, 2021
1 parent ee3e3fd commit bbdecaf
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions modules/utility/include/helpers_android.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

#include "rtc_base/system/arch.h"

// Abort the process if |jni| has a Java exception pending.
// Abort the process if `jni` has a Java exception pending.
// TODO(henrika): merge with CHECK_JNI_EXCEPTION() in jni_helpers.h.
#define CHECK_EXCEPTION(jni) \
RTC_CHECK(!jni->ExceptionCheck()) \
Expand All @@ -37,7 +37,7 @@ namespace webrtc {
// Return a |JNIEnv*| usable on this thread or NULL if this thread is detached.
JNIEnv* GetEnv(JavaVM* jvm);

// Return a |jlong| that will correctly convert back to |ptr|. This is needed
// Return a `jlong` that will correctly convert back to `ptr`. This is needed
// because the alternative (of silently passing a 32-bit pointer to a vararg
// function expecting a 64-bit param) picks up garbage in the high 32 bits.
jlong PointerTojlong(void* ptr);
Expand Down
10 changes: 5 additions & 5 deletions modules/utility/include/jvm_android.h
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,9 @@ class JNIEnvironment {
explicit JNIEnvironment(JNIEnv* jni);
~JNIEnvironment();

// Registers native methods with the Java class specified by |name|.
// Registers native methods with the Java class specified by `name`.
// Note that the class name must be one of the names in the static
// |loaded_classes| array defined in jvm_android.cc.
// `loaded_classes` array defined in jvm_android.cc.
// This method must be called on the construction thread.
std::unique_ptr<NativeRegistration> RegisterNatives(
const char* name,
Expand Down Expand Up @@ -138,7 +138,7 @@ class JNIEnvironment {
// obj = reg->NewObject("<init>", ,);
// }
//
// // Each User method can now use |reg| and |obj| and call Java functions
// // Each User method can now use `reg` and `obj` and call Java functions
// // in WebRtcTest.java, e.g. boolean init() {}.
// bool User::Foo() {
// jmethodID id = reg->GetMethodId("init", "()Z");
Expand Down Expand Up @@ -168,9 +168,9 @@ class JVM {
// called successfully. Use the AttachCurrentThreadIfNeeded class if needed.
std::unique_ptr<JNIEnvironment> environment();

// Returns a JavaClass object given class |name|.
// Returns a JavaClass object given class `name`.
// Note that the class name must be one of the names in the static
// |loaded_classes| array defined in jvm_android.cc.
// `loaded_classes` array defined in jvm_android.cc.
// This method must be called on the construction thread.
JavaClass GetClass(const char* name);

Expand Down
2 changes: 1 addition & 1 deletion modules/utility/source/helpers_android.cc
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ JNIEnv* GetEnv(JavaVM* jvm) {
return reinterpret_cast<JNIEnv*>(env);
}

// Return a |jlong| that will correctly convert back to |ptr|. This is needed
// Return a `jlong` that will correctly convert back to `ptr`. This is needed
// because the alternative (of silently passing a 32-bit pointer to a vararg
// function expecting a 64-bit param) picks up garbage in the high 32 bits.
jlong PointerTojlong(void* ptr) {
Expand Down
4 changes: 2 additions & 2 deletions modules/utility/source/process_thread_impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,11 @@ class ProcessThreadImpl : public ProcessThread {
}

int64_t run_at_ms;
// DelayedTask owns the |task|, but some delayed tasks must be removed from
// DelayedTask owns the `task`, but some delayed tasks must be removed from
// the std::priority_queue, but mustn't be deleted. std::priority_queue does
// not give non-const access to the values, so storing unique_ptr would
// delete the task as soon as it is remove from the priority queue.
// Thus lifetime of the |task| is managed manually.
// Thus lifetime of the `task` is managed manually.
QueuedTask* task;
};
typedef std::list<ModuleCallback> ModuleList;
Expand Down

0 comments on commit bbdecaf

Please sign in to comment.