.github: re-write steps for RC releases from a new branch #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joestringer
reviewed
Jan 6, 2025
| with the title `Prepare for release vX.Y.Z-rc.W` | ||
| - [ ] Submit PR (`../release/internal/submit-release.sh`) | ||
|
|
||
| ## Pre-check (run ~1 week before release date) |
There was a problem hiding this comment.
Is this "release" date, "branch" date or RC0 publish date?
There was a problem hiding this comment.
s/release date/targeted publish date/
joestringer
reviewed
Jan 10, 2025
There was a problem hiding this comment.
I ended up pulling this version of the steps into #288 to build v1.17.0-rc.1. The instructions largely worked. I left a few more bits of feedback below.
aanm
force-pushed
the
pr/rerwite-workflow-for-RC-new-branch
branch
from
3d07fb4 to
7e27419
Compare
|
@joestringer I've addressed your feedback. PTAL at the diff. |
joestringer
approved these changes
Jan 21, 2025
Signed-off-by: André Martins <[email protected]>
aanm
force-pushed
the
pr/rerwite-workflow-for-RC-new-branch
branch
from
7e27419 to
0fd892e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.