Skip to content

Commit

Permalink
Add --regexp, --invert-match and --dry-run options to delete subcommand
Browse files Browse the repository at this point in the history
  • Loading branch information
cions committed Aug 14, 2024
1 parent ee729db commit 9618c39
Show file tree
Hide file tree
Showing 2 changed files with 111 additions and 23 deletions.
119 changes: 96 additions & 23 deletions cmd/leveldb/commands.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import (
"github.com/vmihailenco/msgpack/v5"
)

var leveldbFilenamePattern = regexp.MustCompile(`^(?:LOCK|LOG(?:\.old)?|CURRENT(?:\.bak|\.\d+)?|MANIFEST-\d+|\d+\.(?:ldb|log|sst|tmp))$`)
var leveldbFilenamePattern = regexp.MustCompile(`\A(?:LOCK|LOG(?:\.old)?|CURRENT(?:\.bak|\.\d+)?|MANIFEST-\d+|\d+\.(?:ldb|log|sst|tmp))\z`)

type entry struct {
Key, Value []byte
Expand Down Expand Up @@ -131,6 +131,54 @@ func getKeyRange(c *cli.Context) (*util.Range, error) {
return slice, nil
}

type matcher interface {
Match(key []byte) bool
}

type constMatcher bool

func (m constMatcher) Match(key []byte) bool {
return bool(m)
}

type literalMatcher [][]byte

func (m literalMatcher) Match(key []byte) bool {
for _, pattern := range m {
if bytes.Equal(pattern, key) {
return true
}
}
return false
}

func newLiteralMatcher(keys ...[]byte) literalMatcher {
return keys
}

type regexpMatcher []*regexp.Regexp

func (m regexpMatcher) Match(key []byte) bool {
for _, pattern := range m {
if pattern.Match(key) {
return true
}
}
return false
}

func newRegexpMatcher(patterns ...string) (regexpMatcher, error) {
matcher := make([]*regexp.Regexp, 0, len(patterns))
for _, pattern := range patterns {
re, err := regexp.Compile(pattern)
if err != nil {
return nil, err
}
matcher = append(matcher, re)
}
return matcher, nil
}

func initCmd(c *cli.Context) error {
db, err := leveldb.OpenFile(c.String("dbpath"), &opt.Options{
Comparer: getComparer(c),
Expand Down Expand Up @@ -229,49 +277,74 @@ func deleteCmd(c *cli.Context) error {
if err != nil {
return err
}
inverted := c.Bool("invert-match")
dryRun := c.Bool("dry-run")
keywriter := newPrettyPrinter(color.Output).SetQuoting(true)

batch := new(leveldb.Batch)
for i := 0; i < c.NArg(); i++ {
key, err := getArg(c, i)
var m matcher
if c.NArg() == 0 {
m = constMatcher(true)
} else if c.Bool("regexp") {
m, err = newRegexpMatcher(c.Args().Slice()...)
if err != nil {
return err
}
batch.Delete(key)
} else {
keys := make([][]byte, c.NArg())
for i := range c.NArg() {
key, err := getArg(c, i)
if err != nil {
return err
}
keys = append(keys, key)
}
m = newLiteralMatcher(keys...)
}

db, err := leveldb.OpenFile(c.String("dbpath"), &opt.Options{
Comparer: getComparer(c),
ErrorIfMissing: true,
ReadOnly: dryRun,
})
if err != nil {
return err
}
defer db.Close()

if c.NArg() == 0 {
s, err := db.GetSnapshot()
if err != nil {
return err
}
defer s.Release()
s, err := db.GetSnapshot()
if err != nil {
return err
}
defer s.Release()

iter := s.NewIterator(slice, nil)
defer iter.Release()
for iter.Next() {
batch.Delete(iter.Key())
}
if err := iter.Error(); err != nil {
return err
}
batch := new(leveldb.Batch)

iter.Release()
s.Release()
iter := s.NewIterator(slice, nil)
defer iter.Release()
for iter.Next() {
if m.Match(iter.Key()) != inverted {
if dryRun {
fmt.Print("Would delete ")
keywriter.Write(iter.Key())
fmt.Println()
} else {
batch.Delete(iter.Key())
}
}
}

if err := db.Write(batch, nil); err != nil {
if err := iter.Error(); err != nil {
return err
}

iter.Release()
s.Release()

if !dryRun {
if err := db.Write(batch, nil); err != nil {
return err
}
}

if err := db.Close(); err != nil {
return err
}
Expand Down
15 changes: 15 additions & 0 deletions cmd/leveldb/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,16 @@ func main() {
Aliases: []string{"b"},
Usage: "interpret arguments as base64-encoded",
},
&cli.BoolFlag{
Name: "regexp",
Aliases: []string{"R"},
Usage: "treat arguments as regular expressions",
},
&cli.BoolFlag{
Name: "invert-match",
Aliases: []string{"v"},
Usage: "invert the sense of matching; delete non-matching keys",
},
&cli.StringFlag{
Name: "start",
Aliases: []string{"s"},
Expand Down Expand Up @@ -156,6 +166,11 @@ func main() {
Name: "prefix-base64",
Usage: "limit the key range to a range that satisfy the given `prefix` (base64)",
},
&cli.BoolFlag{
Name: "dry-run",
Aliases: []string{"n"},
Usage: "do not actually delete; just show what would be deleted",
},
},
UseShortOptionHandling: true,
Action: deleteCmd,
Expand Down

0 comments on commit 9618c39

Please sign in to comment.