Skip to content

Commit

Permalink
support/dependencies/check-host-tar.sh: blacklist tar 1.35+
Browse files Browse the repository at this point in the history
GNU tar 1.35 changed the behaviour for the devmajor/devminor fields,
breaking the download hash validation.  For details, see:

https://lists.gnu.org/archive/html/info-gnu/2023-07/msg00005.html
https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/

To work around this issue, blacklist tar 1.35+ similar to how we do it for
pre-1.27 versions so Buildroot falls back to building host-tar (which is
currently 1.34).

Signed-off-by: Peter Korsgaard <[email protected]>
  • Loading branch information
jacmet committed Nov 13, 2023
1 parent ad0bb50 commit f1ee701
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion support/dependencies/check-host-tar.sh
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,12 @@ fi
major_min=1
minor_min=27

if [ $major -lt $major_min ]; then
# Maximal version = 1.34 (1.35 changed devmajor/devminor for files)
# https://lists.gnu.org/archive/html/info-gnu/2023-07/msg00005.html
major_max=1
minor_max=34

if [ $major -lt $major_min -o $major -gt $major_max ]; then
# echo nothing: no suitable tar found
exit 1
fi
Expand All @@ -43,5 +48,10 @@ if [ $major -eq $major_min -a $minor -lt $minor_min ]; then
exit 1
fi

if [ $major -eq $major_max -a $minor -gt $minor_max ]; then
# echo nothing: no suitable tar found
exit 1
fi

# valid
echo $tar

0 comments on commit f1ee701

Please sign in to comment.