Skip to content

Commit

Permalink
hwmon: (adm1029) Ensure the fan_div cache is updated in set_fan_div
Browse files Browse the repository at this point in the history
Writing to fanX_div does not clear the cache. As a result, reading
from fanX_div may return the old value for up to two seconds
after writing a new value.

This patch ensures the fan_div cache is updated in set_fan_div().

Reported-by: Guenter Roeck <[email protected]>
Signed-off-by: Axel Lin <[email protected]>
Cc: [email protected]
Signed-off-by: Guenter Roeck <[email protected]>
  • Loading branch information
AxelLin authored and groeck committed Jul 3, 2014
1 parent df86754 commit 1035a9e
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/hwmon/adm1029.c
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,9 @@ static ssize_t set_fan_div(struct device *dev,
/* Update the value */
reg = (reg & 0x3F) | (val << 6);

/* Update the cache */
data->fan_div[attr->index] = reg;

/* Write value */
i2c_smbus_write_byte_data(client,
ADM1029_REG_FAN_DIV[attr->index], reg);
Expand Down

0 comments on commit 1035a9e

Please sign in to comment.