feat(core): Genericize execution migrators (spinnaker#2355)

Squashes PollingAgentExecutionRepository methods into the
root ExecutionRepository interface. This separatino was more
pain that it was worth.

Pulled forward the DualExecutionRepository that was written
for Orca SQL into orca-core.

For the main show, I've refactored the two execution data
migrators so that they're persistence backend agnostic.
Combined with DualExecutionRepository, you can migrate from
one backend to another without writing new migration logic,
making the operational story a little simpler for an already
tough process.

orca-core-tck/src/main/groovy/com/netflix/spinnaker/orca/pipeline/persistence/ExecutionRepositoryTck.groovy

@@ -534,5 +534,39 @@ abstract class ExecutionRepositoryTck<T extends ExecutionRepository> extends Spe
     [RUNNING, SUCCEEDED] | 1     | PIPELINE      | 1
     [RUNNING, SUCCEEDED] | 1     | ORCHESTRATION | 1
   }
+
+  def "can retrieve all application names in database, type: #executionType, min: #minExecutions"() {
+    given:
+    def execution1 = pipeline {
+      application = "spindemo"
+    }
+    def execution2 = pipeline {
+      application = "orca"
+    }
+    def execution3 = orchestration {
+      application = "spindemo"
+    }
+    def execution4 = orchestration {
+      application = "spindemo"
+    }
+
+    when:
+    repository.store(execution1)
+    repository.store(execution2)
+    repository.store(execution3)
+    repository.store(execution4)
+    def apps = repository.retrieveAllApplicationNames(executionType, minExecutions)
+
+    then:
+    apps.sort() == expectedApps.sort()
+
+    where:
+    executionType | minExecutions || expectedApps
+    ORCHESTRATION | 0             || ["spindemo"]
+    PIPELINE      | 0             || ["spindemo", "orca"]
+    null          | 0             || ["spindemo", "orca"]
+    null          | 2             || ["spindemo"]
+    PIPELINE      | 2             || []
+  }
 }
 

orca-core/src/main/java/com/netflix/spinnaker/orca/notifications/scheduling/OldPipelineCleanupPollingNotificationAgent.java

@@ -22,6 +22,7 @@
 import com.netflix.spinnaker.orca.notifications.AbstractPollingNotificationAgent;
 import com.netflix.spinnaker.orca.notifications.NotificationClusterLock;
 import com.netflix.spinnaker.orca.pipeline.model.Execution;
+import com.netflix.spinnaker.orca.pipeline.persistence.ExecutionRepository;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -83,7 +84,7 @@ public Boolean call(Execution execution) {
   };
 
   private final Clock clock;
-  private final PollingAgentExecutionRepository executionRepository;
+  private final ExecutionRepository executionRepository;
   private final Registry registry;
 
   private final long pollingIntervalMs;
@@ -95,7 +96,7 @@ public Boolean call(Execution execution) {
 
   @Autowired
   public OldPipelineCleanupPollingNotificationAgent(NotificationClusterLock clusterLock,
-                                                    PollingAgentExecutionRepository executionRepository,
+                                                    ExecutionRepository executionRepository,
                                                     Clock clock,
                                                     Registry registry,
                                                     @Value("${pollers.oldPipelineCleanup.intervalMs:3600000}") long pollingIntervalMs,
@@ -169,7 +170,7 @@ private void cleanup(List<PipelineExecutionDetails> executions) {
     executions.subList(0, (executions.size() - minimumPipelineExecutions)).forEach(p -> {
       long startTime = p.startTime == null ? p.buildTime : p.startTime;
       long days = ChronoUnit.DAYS.between(Instant.ofEpochMilli(startTime), Instant.ofEpochMilli(clock.millis()));
-      if (days > thresholdDays && !executionRepository.hasEntityTags(PIPELINE, p.id)) {
+      if (days > thresholdDays) {
         log.info("Deleting pipeline execution " + p.id + ": " + p.toString());
         registry.counter(deletedId.withTag("application", p.application)).increment();
         executionRepository.delete(PIPELINE, p.id);

orca-core/src/main/java/com/netflix/spinnaker/orca/notifications/scheduling/TopApplicationExecutionCleanupPollingNotificationAgent.java

@@ -23,6 +23,7 @@
 import com.netflix.spinnaker.orca.notifications.AbstractPollingNotificationAgent;
 import com.netflix.spinnaker.orca.notifications.NotificationClusterLock;
 import com.netflix.spinnaker.orca.pipeline.model.Execution;
+import com.netflix.spinnaker.orca.pipeline.persistence.ExecutionRepository;
 import com.netflix.spinnaker.orca.pipeline.persistence.ExecutionRepository.ExecutionCriteria;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -66,7 +67,7 @@ public class TopApplicationExecutionCleanupPollingNotificationAgent extends Abst
     return builder;
   };
 
-  private final PollingAgentExecutionRepository executionRepository;
+  private final ExecutionRepository executionRepository;
   private final Registry registry;
   private final long pollingIntervalMs;
   private final int threshold;
@@ -76,7 +77,7 @@ public class TopApplicationExecutionCleanupPollingNotificationAgent extends Abst
 
   @Autowired
   public TopApplicationExecutionCleanupPollingNotificationAgent(NotificationClusterLock clusterLock,
-                                                                PollingAgentExecutionRepository executionRepository,
+                                                                ExecutionRepository executionRepository,
                                                                 Registry registry,
                                                                 @Value("${pollers.topApplicationExecutionCleanup.intervalMs:3600000}") long pollingIntervalMs,
                                                                 @Value("${pollers.topApplicationExecutionCleanup.threshold:2500}") int threshold) {