chore(warnings): replace String::split with Splitter::on

This usage was particularly dangerous:

  String[] bits = type.split("\\.");
  return bits[bits.length - 1];

Depending on the input string, bits could be an empty list.
Also on every call of the method, the regex needs to be compiled.

See http://errorprone.info/bugpattern/StringSplitter

orca-pipelinetemplate/src/main/java/com/netflix/spinnaker/orca/pipelinetemplate/v1schema/model/StageDefinition.java

@@ -16,6 +16,7 @@
 package com.netflix.spinnaker.orca.pipelinetemplate.v1schema.model;
 
 import com.fasterxml.jackson.annotation.JsonIgnore;
+import com.google.common.base.Splitter;
 
 import java.util.ArrayList;
 import java.util.Collection;
@@ -28,7 +29,7 @@
 import java.util.LinkedHashSet;
 
 public class StageDefinition implements Identifiable, Conditional, Cloneable {
-
+  private static final Splitter ON_DOTS = Splitter.on(".");
   private String id;
   private String name;
   private InjectionRule inject;
@@ -308,8 +309,9 @@ public String getPartialId() {
     if (type == null) {
       return null;
     }
-    String[] bits = type.split("\\.");
-    return bits[bits.length - 1];
+
+    List<String> bits =  ON_DOTS.splitToList(type);
+    return bits.get(bits.size() - 1);
   }
 
   public PartialDefinitionContext getPartialDefinitionContext() {

orca-pipelinetemplate/src/main/java/com/netflix/spinnaker/orca/pipelinetemplate/v1schema/render/tags/ModuleTag.java

@@ -17,6 +17,7 @@
 
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
+import com.google.common.base.Splitter;
 import com.hubspot.jinjava.interpret.Context;
 import com.hubspot.jinjava.interpret.InterpretException;
 import com.hubspot.jinjava.interpret.JinjavaInterpreter;
@@ -45,6 +46,7 @@
 import java.util.stream.Collectors;
 
 public class ModuleTag implements Tag {
+  private static final Splitter ON_EQUALS = Splitter.on("=");
 
   private Renderer renderer;
   private ObjectMapper objectMapper;
@@ -91,11 +93,11 @@ public String interpret(TagNode tagNode, JinjavaInterpreter interpreter) {
     // Assign parameters into the context
     Map<String, String> paramPairs = new HashMap<>();
     helper.subList(1, helper.size()).forEach(p -> {
-      String[] parts = p.split("=");
-      if (parts.length != 2) {
+      List<String> parts = ON_EQUALS.splitToList(p);
+      if (parts.size() != 2) {
         throw new TemplateSyntaxException(tagNode.getMaster().getImage(), "Tag 'module' expects parameters to be in a 'key=value' format: " + helper, tagNode.getLineNumber());
       }
-      paramPairs.put(parts[0], parts[1]);
+      paramPairs.put(parts.get(0), parts.get(1));
     });
 
     List<String> missing = new ArrayList<>();

orca-pipelinetemplate/src/main/java/com/netflix/spinnaker/orca/pipelinetemplate/v1schema/render/tags/PipelineIdTag.java

@@ -15,6 +15,7 @@
  */
 
 package com.netflix.spinnaker.orca.pipelinetemplate.v1schema.render.tags;
+import com.google.common.base.Splitter;
 import com.hubspot.jinjava.interpret.Context;
 import com.hubspot.jinjava.interpret.JinjavaInterpreter;
 import com.hubspot.jinjava.interpret.TemplateSyntaxException;
@@ -34,6 +35,7 @@
 public class PipelineIdTag implements Tag {
   private static final String APPLICATION = "application";
   private static final String NAME = "name";
+  private static final Splitter ON_EQUALS = Splitter.on("=");
 
   private final Front50Service front50Service;
 
@@ -50,12 +52,12 @@ public String interpret(TagNode tagNode, JinjavaInterpreter interpreter) {
 
     Map<String, String> paramPairs = new HashMap<>();
     helper.forEach(p -> {
-      String[] parts = p.split("=");
-      if (parts.length != 2) {
+      List<String> parts = ON_EQUALS.splitToList(p);
+      if (parts.size() != 2) {
         throw new TemplateSyntaxException(tagNode.getMaster().getImage(), "Tag 'pipelineId' expects parameters to be in a 'key=value' format: " + helper, tagNode.getLineNumber());
       }
 
-      paramPairs.put(parts[0], parts[1]);
+      paramPairs.put(parts.get(0), parts.get(1));
     });
 
     Context context = interpreter.getContext();

orca-pipelinetemplate/src/main/java/com/netflix/spinnaker/orca/pipelinetemplate/v1schema/render/tags/StrategyIdTag.java

@@ -1,5 +1,6 @@
 package com.netflix.spinnaker.orca.pipelinetemplate.v1schema.render.tags;
 
+import com.google.common.base.Splitter;
 import com.hubspot.jinjava.interpret.Context;
 import com.hubspot.jinjava.interpret.JinjavaInterpreter;
 import com.hubspot.jinjava.interpret.TemplateSyntaxException;
@@ -13,6 +14,7 @@
 import java.util.*;
 
 public class StrategyIdTag implements Tag {
+  private static final Splitter ON_EQUALS = Splitter.on("=");
   private static final String APPLICATION = "application";
   private static final String NAME = "name";
 
@@ -41,12 +43,12 @@ public String interpret(TagNode tagNode, JinjavaInterpreter interpreter) {
 
     Map<String, String> paramPairs = new HashMap<>();
     helper.forEach(p -> {
-        String[] parts = p.split("=");
-        if (parts.length != 2) {
-            throw new TemplateSyntaxException(tagNode.getMaster().getImage(), "Tag 'strategyId' expects parameters to be in a 'key=value' format: " + helper, tagNode.getLineNumber());
-        }
+      List<String> parts = ON_EQUALS.splitToList(p);
+      if (parts.size() != 2) {
+          throw new TemplateSyntaxException(tagNode.getMaster().getImage(), "Tag 'strategyId' expects parameters to be in a 'key=value' format: " + helper, tagNode.getLineNumber());
+      }
 
-        paramPairs.put(parts[0], parts[1]);
+      paramPairs.put(parts.get(0), parts.get(1));
     });
 
     Context context = interpreter.getContext();