Drop support for GHC versions older than 9.6 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some dependencies were both in `basic-config` and in `library`. Furthermore, they were not sorted alphabetically.
DigitalBrains1
force-pushed
the
minimum-96
branch
from
f88d19c to
7031394
Compare
In preparation for the next commit, we drop older GHC's from CI We have separate Docker images for Clash 1.8 and Clash master; use them correctly.
DigitalBrains1
force-pushed
the
minimum-96
branch
from
7031394 to
10901c2
Compare
martijnbastiaan
approved these changes
Feb 7, 2025
Rationale: - With at least GHC 9.2, we can use `OverloadedRecordDot` - GHC 9.2 itself doesn't work well with Clash. It has indecipherable error messages. - With at least GHC 9.4, we can use `OPAQUE` - GHC 9.4 itself doesn't work well with Clash. Versions 9.4.8 is extremely slow. Possibly there are several more good reasons as well, this list is not meant to be exhaustive. Using `--prefer-oldest`, I could not even get Cabal to give me an older `prettyprinter` package than 1.7.0 with GHC 9.6.1. So raising the lower bound of `prettyprinter` is completely harmless.
DigitalBrains1
force-pushed
the
minimum-96
branch
from
10901c2 to
bde4360
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we require GHC 9.6, we can start really using features only present in newer GHC's. We can also drop quite some compatibility stuff and we make further development of the package easier.
OverloadedRecordDotOPAQUEPossibly there are several more good reasons as well, this list is not meant to be exhaustive.
Several open PR's require
clash-protocolsas a dependency. Adding that dependency already meant dropping support for GHC 8.10; it was what triggered this PR to be written.