Add --prep-only option to run preparatory work only #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phmccarty
reviewed
Oct 23, 2017
| @@ -175,6 +178,14 @@ def main(): | |||
| "-a/--archives or options.conf['package']['archives'] requires an " | |||
| "even number of arguments")) | |||
|
|
|||
| if args.prep_only: | |||
| package(args, url, name, archives, "./workingdir") | |||
There was a problem hiding this comment.
I see an empty directory called "output" within workingdir. Is that directory supposed to be empty?
There was a problem hiding this comment.
I've removed the unused output directory
For non-autospec enabled packages this option can be used to download the upstream tarball, any specified archives, extract them and put the archives at their destination, and update the upstream file, but not actually attempt to build a specfile. Signed-off-by: Matthew Johnson <[email protected]>
Since moving output to a temporary directory, the "output" directory has fallen out of use. Remove the output directory from autospec. Signed-off-by: Matthew Johnson <[email protected]>
Save the package metadata to the ./workingdir directory for --prep-only runs. Signed-off-by: Matthew Johnson <[email protected]>
Also move the prep work into its own function to make it easier to manage if it continues to grow. Signed-off-by: Matthew Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For non-autospec enabled packages this option can be used to download
the upstream tarball, any specified archives, extract them and put the
archives at their destination, and update the upstream file, but not
actually attempt to build a specfile.
Signed-off-by: Matthew Johnson [email protected]