Skip to content

feat(localizations): Remove not_allowed_access from en_* files #5701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025

Conversation

tmilewski
Copy link
Member

Description

Removes not_allowed_access error codes from en_* localization files. This will allow the API to return more-context-specific English error messages.

With this change, I've also updated/translated not_allowed_access errors in non-english-based localization files.

Translated Message:

The email address or phone number is not allowed to sign up. This could be due to using '+', '=', '#', or '.' in your email address, using a domain connected with a temporary email service, or being explicitly blocked. If you believe this is an error, please contact support.

ECO-618

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@tmilewski tmilewski self-assigned this Apr 23, 2025
Copy link

changeset-bot bot commented Apr 23, 2025

🦋 Changeset detected

Latest commit: caed6bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Minor
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 2:20pm

@tmilewski
Copy link
Member Author

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @tmilewski - the snapshot version command generated the following package versions:

Package Version
@clerk/agent-toolkit 0.0.26-snapshot.v20250423174611
@clerk/astro 2.6.8-snapshot.v20250423174611
@clerk/backend 1.29.3-snapshot.v20250423174611
@clerk/chrome-extension 2.3.0-snapshot.v20250423174611
@clerk/clerk-js 5.62.1-snapshot.v20250423174611
@clerk/elements 0.23.18-snapshot.v20250423174611
@clerk/clerk-expo 2.10.0-snapshot.v20250423174611
@clerk/expo-passkeys 0.2.10-snapshot.v20250423174611
@clerk/express 1.4.9-snapshot.v20250423174611
@clerk/fastify 2.2.9-snapshot.v20250423174611
@clerk/localizations 3.14.0-snapshot.v20250423174611
@clerk/nextjs 6.18.0-snapshot.v20250423174611
@clerk/nuxt 1.5.9-snapshot.v20250423174611
@clerk/clerk-react 5.30.0-snapshot.v20250423174611
@clerk/react-router 1.3.0-snapshot.v20250423174611
@clerk/remix 4.6.0-snapshot.v20250423174611
@clerk/shared 3.7.4-snapshot.v20250423174611
@clerk/tanstack-react-start 0.14.0-snapshot.v20250423174611
@clerk/testing 1.5.1-snapshot.v20250423174611
@clerk/themes 2.2.36-snapshot.v20250423174611
@clerk/types 4.55.1-snapshot.v20250423174611
@clerk/vue 1.6.5-snapshot.v20250423174611

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/agent-toolkit

npm i @clerk/[email protected] --save-exact

@clerk/astro

npm i @clerk/[email protected] --save-exact

@clerk/backend

npm i @clerk/[email protected] --save-exact

@clerk/chrome-extension

npm i @clerk/[email protected] --save-exact

@clerk/clerk-js

npm i @clerk/[email protected] --save-exact

@clerk/elements

npm i @clerk/[email protected] --save-exact

@clerk/clerk-expo

npm i @clerk/[email protected] --save-exact

@clerk/expo-passkeys

npm i @clerk/[email protected] --save-exact

@clerk/express

npm i @clerk/[email protected] --save-exact

@clerk/fastify

npm i @clerk/[email protected] --save-exact

@clerk/localizations

npm i @clerk/[email protected] --save-exact

@clerk/nextjs

npm i @clerk/[email protected] --save-exact

@clerk/nuxt

npm i @clerk/[email protected] --save-exact

@clerk/clerk-react

npm i @clerk/[email protected] --save-exact

@clerk/react-router

npm i @clerk/[email protected] --save-exact

@clerk/remix

npm i @clerk/[email protected] --save-exact

@clerk/shared

npm i @clerk/[email protected] --save-exact

@clerk/tanstack-react-start

npm i @clerk/[email protected] --save-exact

@clerk/testing

npm i @clerk/[email protected] --save-exact

@clerk/themes

npm i @clerk/[email protected] --save-exact

@clerk/types

npm i @clerk/[email protected] --save-exact

@clerk/vue

npm i @clerk/[email protected] --save-exact

'@clerk/localizations': minor
---

Remove `not_allowed_access` localizations from `en_*` localization files to rely on more-specific API-based error messages.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it feels a bit wrong that only the english version will benefit from this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panteliselef This is true, though Braden and I have follow-on work planned.

Copy link
Member

@anagstef anagstef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small note here. I'm not sure how the packages/localizations/src/utils/generate.ts script will behave now, if we still use it to align the localization keys on every file.

@tmilewski
Copy link
Member Author

Just a small note here. I'm not sure how the packages/localizations/src/utils/generate.ts script will behave now, if we still use it to align the localization keys on every file.

@anagstef Good catch, updating now!

@tmilewski tmilewski force-pushed the tm/eco-618-remove-not-allowed-access branch from bcadd7a to caed6bb Compare April 24, 2025 14:19
@tmilewski tmilewski merged commit 7cd1afa into main Apr 24, 2025
31 checks passed
@tmilewski tmilewski deleted the tm/eco-618-remove-not-allowed-access branch April 24, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants