-
Notifications
You must be signed in to change notification settings - Fork 346
fix(clerk-js,types): Ensure proper checkout plandetails drawer is opened within profile components #5779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 870c478 The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…io-bug-with-shared-checkout-drawer
fa4b4a0
to
7b8fe53
Compare
…io-bug-with-shared-checkout-drawer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Fixes issue where if two Profile components were rendered at once, the Checkout and PlanDetails drawers would be only portal'd into the first instance on the page.
The PR refactors the drawer functionality to use portalRoot instead of the id to be able to select the closest profile root that we should be rendering within.
I've also updated to use a data attribute vs id to avoid duplicate ids on the page.
BEFORE:
before.mov
AFTER:
after.mov
Fixes COM-688
Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change