Skip to content

fix(clerk-js): User total due now in checkout flows instead of grand total #5794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

octoper
Copy link
Member

@octoper octoper commented May 2, 2025

Description

This PR changes all the usages of grand_total with total_due_now

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

vercel bot commented May 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2025 8:52am

Copy link

changeset-bot bot commented May 2, 2025

🦋 Changeset detected

Latest commit: b60194a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@octoper octoper changed the title chore(clerk-js): Remove grand_total usage from checkout flows chore(clerk-js): User total due now in checkout flows instead of grand total May 2, 2025
@octoper octoper changed the title chore(clerk-js): User total due now in checkout flows instead of grand total fix(clerk-js): User total due now in checkout flows instead of grand total May 2, 2025
@octoper octoper marked this pull request as ready for review May 2, 2025 08:26
@octoper octoper force-pushed the vaggelis/com-721-remove-grandtotal-from-checkout-in-favour-of-total_due_now branch from 41d3b38 to 0cefb92 Compare May 2, 2025 08:40
@octoper octoper requested a review from kostaspt May 2, 2025 08:51
@octoper octoper force-pushed the vaggelis/com-721-remove-grandtotal-from-checkout-in-favour-of-total_due_now branch from 0cefb92 to b60194a Compare May 2, 2025 08:51
@octoper octoper self-assigned this May 2, 2025
@octoper octoper merged commit edaa1b9 into main May 2, 2025
34 checks passed
@octoper octoper deleted the vaggelis/com-721-remove-grandtotal-from-checkout-in-favour-of-total_due_now branch May 2, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants