Skip to content

feat(clerk-js,localizations,types): Pay with test card button on <AddPaymentSource /> component #5831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

nikospapcom
Copy link
Member

@nikospapcom nikospapcom commented May 5, 2025

Description

This pr adds the Pay with test card section in the Checkout form
In the add payment method section we still use the test card details instead

Screenshot 2025-05-05 at 5 10 55 PM

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

User Profile

Screen.Recording.2025-05-05.at.5.07.34.PM.mov

Organization Profile

Screen.Recording.2025-05-05.at.5.09.17.PM.mov

@nikospapcom nikospapcom self-assigned this May 5, 2025
Copy link

changeset-bot bot commented May 5, 2025

🦋 Changeset detected

Latest commit: b2f4546

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/types Patch
@clerk/clerk-react Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/agent-toolkit Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/elements Patch
@clerk/expo-passkeys Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/remix Patch
@clerk/shared Patch
@clerk/tanstack-react-start Patch
@clerk/testing Patch
@clerk/themes Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2025 1:58pm

@nikospapcom nikospapcom changed the title feat(clerk-js,localizations,types): Add Pay with test card button on <AddPaymentSource /> component feat(clerk-js,localizations,types): Pay with test card button on <AddPaymentSource /> component May 5, 2025
@nikospapcom nikospapcom force-pushed the nikospap/add-pay-with-test-card-section branch 2 times, most recently from 125b5cc to 7a8eebd Compare May 5, 2025 13:49
@nikospapcom nikospapcom force-pushed the nikospap/add-pay-with-test-card-section branch from 7a8eebd to b2f4546 Compare May 5, 2025 13:57
@nikospapcom nikospapcom requested a review from octoper May 5, 2025 14:04
@nikospapcom nikospapcom marked this pull request as ready for review May 5, 2025 14:14
@drewwilson
Copy link

I think we can remove the "Pay with test card" after you've already added a card.
So basically IF you have no payment method, show the "Pay with test card" block.. if you DO have a saved payment method, never show it.
Since you can just use the saved payment method.

Copy link
Member

@alexcarpenter alexcarpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@nikospapcom
Copy link
Member Author

I think we can remove the "Pay with test card" after you've already added a card. So basically IF you have no payment method, show the "Pay with test card" block.. if you DO have a saved payment method, never show it. Since you can just use the saved payment method.

@drewwilson I'd say that we need to keep the button. The reason behind is that in the next month the test card will be expired so we want to have this button there

@nikospapcom nikospapcom merged commit 322c43f into main May 5, 2025
34 checks passed
@nikospapcom nikospapcom deleted the nikospap/add-pay-with-test-card-section branch May 5, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants