Skip to content

fix(clerk-js): Correctly pass newSubscriptionRedirectUrl to checkout drawer #5909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alexcarpenter
Copy link
Member

Description

Fixes an issue where newSubscriptionRedirectUrl usage on PricingTable component had no effect.

Fixes COM-788

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented May 12, 2025

🦋 Changeset detected

Latest commit: 4dfdd34

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2025 5:49pm

Copy link
Member

@panteliselef panteliselef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a e2e test ?

@alexcarpenter
Copy link
Member Author

Can you add a e2e test ?

@panteliselef added here 0fa7519

@alexcarpenter alexcarpenter merged commit 2b18d7a into main May 13, 2025
32 checks passed
@alexcarpenter alexcarpenter deleted the alexcarpenter/com-788-investigate-newsubscriptionredirecturl-prop-in-pricingtable branch May 13, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants